Add EventFilter encoding #11178
Merged
Add EventFilter encoding #11178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
austinh0,
balducci-apple,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chulspro,
Damian-Nordic,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
kpschoedel,
LuDuda,
mrjerryjohns,
msandstedt,
mspang,
pan-apple,
robszewczyk,
sagar-apple,
saurabhst,
selissia and
tcarmelveilleux
pullapprove
bot
requested review from
tecimovic,
vivien-apple,
wbschiller and
woody-apple
|
PR #11178: Size comparison from 1e27d92 to 3de84f2 Full report (37 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
yunhanw-google
force-pushed
the
feature/add_event_filter
branch
from
3de84f2 to
1a8a5df
Compare
|
PR #11178: Size comparison from 06f9a38 to 1a8a5df Increases (1 build for esp32)
Full report (37 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
yufengwangca
approved these changes
Oct 29, 2021
jmartinez-silabs
approved these changes
Oct 29, 2021
mrjerryjohns
approved these changes
Oct 29, 2021
bzbarsky-apple
requested changes
Oct 29, 2021
There was a problem hiding this comment.
So two things:
- This is not usable as-is because of the Init problem.
- This general pattern does not seem right to me. Instead, I think we should take an approach more like what we did in cluster-objects. Specifically, have a
EventFilterIBstruct with Encode/Decode methods on it. Consumers then instantiate the struct and either fill it in and call Encode() or call Decode to fill it in.
In this case, the whole thing should be <50 lines of code, I would expect.
yunhanw-google
force-pushed
the
feature/add_event_filter
branch
from
1a8a5df to
ba0755d
Compare
|
PR #11178: Size comparison from 345723d to ba0755d Increases (1 build for esp32)
Full report (37 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
bzbarsky-apple
approved these changes
Oct 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Add EventFilter encoding, which would be used for ReadRequest and Subscribe request encoding per latest IM spec.
https://github.com/CHIP-Specifications/connectedhomeip-spec/blob/master/src/data_model/Encoding-Specification.adoc#encoding-ReadRequestMessage
https://github.com/CHIP-Specifications/connectedhomeip-spec/blob/master/src/data_model/Encoding-Specification.adoc#encoding-SubscribeRequestMessage
Change overview
What's in this PR
Testing
Add unit tests for EventFilter