[examples] Update nrfconnect pump examples #11127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added dummy get functions for pressure and flow. Added the possibility to factory reset the device with a longpress on one of the buttons. Updated the .sysconfig file so it can be opened with sysconfig.
…ferences. Added reset feature in the app. Reduced target heap size to allow the project to build again. Updated .sysconfig file so it loads correctly in SysConfig.
…ect accessor methods
…t pump examples. Added update of on/off cluster when button is pressed in TI pump examples so they match the nrfconnect example behavior.
…fconnect_Pump_Examples
…ute is no longer enabled
|
PR #11127: Size comparison from 36329e1 to d443f60 Increases above 0.2%:
Increases (2 builds for esp32, nrfconnect)
Decreases (1 build for nrfconnect)
Full report (37 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
Damian-Nordic
approved these changes
Oct 28, 2021
examples/pump-controller-app/nrfconnect/main/include/PumpManager.h
Outdated
Show resolved
Hide resolved
andy31415
approved these changes
Oct 28, 2021
|
fast track: platform-specific changes and app-specific changes only |
|
@andersbangGF please fix restyle issues for this to be mergeable |
|
@andersbangGF Can you please restyle? Normally I do this for people: However it sounds like you've enabled write protection. If you disable it, other members can help you out :) |
bzbarsky-apple
approved these changes
Oct 29, 2021
@woody-apple Sorry I missed the restyle yesterday - It's fixed now. Thanks for pointing out the access right problem. I'll look into why our instance is set up as it is. |
|
PR #11127: Size comparison from bf585f8 to cbb5e17 Full report (5 builds for p6, qpg, telink)
|
|
PR #11127: Size comparison from bf585f8 to 79651e4 Increases above 0.2%:
Increases (1 build for nrfconnect)
Decreases (1 build for nrfconnect)
Full report (37 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
PSONALl
pushed a commit
to PSONALl/connectedhomeip
that referenced
this pull request
Dec 3, 2021
* Update pump-app and documentation removing old lock-app code. Added dummy get functions for pressure and flow. Added the possibility to factory reset the device with a longpress on one of the buttons. Updated the .sysconfig file so it can be opened with sysconfig. * Restyled * Update pump-controller-app and documentation removing old lock-app references. Added reset feature in the app. Reduced target heap size to allow the project to build again. Updated .sysconfig file so it loads correctly in SysConfig. * Restyle changed files * Restyled by whitespace * Removed submodule added from bad merge. * Reverted zap repo to correct version * Corrected spelling * Enabled extended discovery to support multiadmin on TI platform * Restyled by whitespace * pump-app: Replaced use of emberAfWriteServerAttribute calls with correct accessor methods * Fixed a typo in the log output for UpdateClusterState * Replaced usage of emberAf call's with correct accessors for nrfconnect pump examples. Added update of on/off cluster when button is pressed in TI pump examples so they match the nrfconnect example behavior. * Minor merge fixes. Built all pump examples (nrf + TI) * Fixed bad merge of AppTask.cpp for TI Pump-app * Fix bad merge of pump-manager for TI Pump App * One more attempt to fix bad merge. * Corrected type on maxSpeed attribute for pump-app * Removed On/Off cluster update from pump-controller-apps as the attribute is no longer enabled * revert submodule * Restyled by whitespace * Removed unused declarations from pump manager in pump-controller-app * Regen ZAP Co-authored-by: Restyled.io <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The nrfConnect examples was not up to date wit support for the latest attibutes etc. implemented in the TI examples
Change overview
Testing
Built all pump apps for both nrfconnect and TI (pump-app and pump-controller-app)
Tested all builds with chip-tool