Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[im] Fix wildcard path support per spec #11115

Merged
merged 3 commits into from
Nov 4, 2021
Merged

[im] Fix wildcard path support per spec #11115

merged 3 commits into from
Nov 4, 2021

Conversation

erjiaqing
Copy link
Contributor

@erjiaqing erjiaqing commented Oct 28, 2021 •
edited
Loading

Problem

  • The current implementation of ClusterInfo class is not handling wildcard paths correctly.
  • Spec requirement: wildcard by omitting fields

Change overview

  • Fix the logic for handling wildcard paths.
  • Uses Optional for missing values, and changes the usages to .Value()
  • Assume ClusterInfo values are concrete path now, this will be changed in Wildcard support for IM Read interaction #8364
  • Update tests to use SetValue, ClearValue

Testing

Updtaes existing test, the logic is covered by existing src/app/tests/TestClusterInfo.cpp

@todo
Copy link

todo bot commented Oct 28, 2021

We did not make uses of list index in ClusterInfo now.

connectedhomeip/src/app/ClusterInfo.h

Lines 66 to 75 in a008736

// TODO: We did not make uses of list index in ClusterInfo now.
return true;
}
bool HasWildcard() const { return !mFlags.HasAll(Flags::kEndpointIdValid, Flags::kClusterIdValid, Flags::kFieldIdValid); }
ClusterInfo() {}
NodeId mNodeId = 0;
ClusterId mClusterId = 0;

This comment was generated by todo based on a TODO comment in a008736 in #11115. cc @erjiaqing.

@boring-cyborg boring-cyborg bot added the app label Oct 28, 2021
@todo
Copy link

todo bot commented Oct 28, 2021

Supports wildcard paths here

connectedhomeip/src/app/ReadHandler.cpp

Lines 336 to 344 in a008736

// TODO: Supports wildcard paths here
err = path.GetNodeId(&(clusterInfo.mNodeId));
if (err == CHIP_END_OF_TLV)
{
err = CHIP_NO_ERROR;
}
SuccessOrExit(err);
err = path.GetEndpointId(&(clusterInfo.mEndpointId));
SuccessOrExit(err);

This comment was generated by todo based on a TODO comment in a008736 in #11115. cc @erjiaqing.

@github-actions
Copy link

github-actions bot commented Nov 2, 2021 •
edited
Loading

PR #11115: Size comparison from 12ec702 to b9c232b

Decreases (29 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 12ec702 b9c232b change % change
efr32 lighting-app BRD4161A (read only) 735400 734312 -1088 -0.1
.text 735392 734304 -1088 -0.1
BRD4161A+rpc (read only) 722840 721752 -1088 -0.2
.text 722832 721744 -1088 -0.2
lock-app BRD4161A (read only) 714684 713600 -1084 -0.2
.text 714676 713592 -1084 -0.2
window-app BRD4161A (read only) 715596 714508 -1088 -0.2
.text 715588 714500 -1088 -0.2
esp32 all-clusters-app c3devkit (read only) 880170 879858 -312 -0.0
(read/write) 1307552 1307104 -448 -0.0
.flash.rodata 199424 198976 -448 -0.2
.flash.text 880170 879858 -312 -0.0
m5stack (read only) 911115 910971 -144 -0.0
(read/write) 427312 426872 -440 -0.1
.flash.rodata 208128 207688 -440 -0.2
.flash.text 911115 910971 -144 -0.0
k32w lighting-app k32w061+se05x+release (read/write) 698232 698120 -112 -0.0
.text 612844 612732 -112 -0.0
lock-app k32w061+debug (read/write) 590524 590412 -112 -0.0
.text 514672 514560 -112 -0.0
linux all-clusters-app debug (read only) 1684105 1681705 -2400 -0.1
(read/write) 118992 118928 -64 -0.1
.bss 50608 50544 -64 -0.1
.rodata 137845 136853 -992 -0.7
.text 1413202 1411794 -1408 -0.1
bridge-app debug+rpc (read only) 1278533 1276133 -2400 -0.2
(read/write) 84104 84040 -64 -0.1
.bss 50768 50704 -64 -0.1
.rodata 109604 108612 -992 -0.9
.text 1073685 1072277 -1408 -0.1
chip-tool debug (read only) 4312925 4310509 -2416 -0.1
(read/write) 123552 123488 -64 -0.1
.bss 17680 17616 -64 -0.4
.rodata 217488 216528 -960 -0.4
.text 3829781 3828325 -1456 -0.0
lighting-app debug+rpc (read only) 1537505 1535105 -2400 -0.2
(read/write) 100976 100912 -64 -0.1
.bss 40152 40088 -64 -0.2
.rodata 127761 126769 -992 -0.8
.text 1277362 1275954 -1408 -0.1
ota-provider-app debug (read only) 1236425 1234025 -2400 -0.2
(read/write) 67072 67008 -64 -0.1
.bss 36608 36544 -64 -0.2
.rodata 110376 109384 -992 -0.9
.text 1029922 1028514 -1408 -0.1
ota-requestor-app debug (read only) 1293697 1291265 -2432 -0.2
(read/write) 76392 76328 -64 -0.1
.bss 44864 44800 -64 -0.1
.rodata 121600 120576 -1024 -0.8
.text 1074306 1072898 -1408 -0.1
tv-app debug (read only) 1770905 1768537 -2368 -0.1
(read/write) 288536 288472 -64 -0.0
.bss 222192 222128 -64 -0.0
.rodata 153176 152216 -960 -0.6
.text 1475826 1474418 -1408 -0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2293608 2293544 -64 -0.0
.text 1256208 1256144 -64 -0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2272736 2272616 -120 -0.0
.text 1235336 1235216 -120 -0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2250392 2250336 -56 -0.0
.text 1212992 1212936 -56 -0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 860175 860079 -96 -0.0
text 577052 576944 -108 -0.0
nrf52840dk_nrf52840+rpc (read/write) 820999 820903 -96 -0.0
text 550224 550120 -104 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 785218 785106 -112 -0.0
text 506520 506412 -108 -0.0
lock-app nrf52840dk_nrf52840 (read/write) 836883 836771 -112 -0.0
text 558532 558424 -108 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 762178 762066 -112 -0.0
text 488092 487984 -108 -0.0
pump-app nrf52840dk_nrf52840 (read/write) 842863 842751 -112 -0.0
text 562588 562484 -104 -0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 836739 836627 -112 -0.0
text 558268 558160 -108 -0.0
p6 lock-app default (read/write) 2166560 2165464 -1096 -0.1
.text 1124824 1123728 -1096 -0.1
qpg lighting-app qpg6100+debug (read only) 489680 489560 -120 -0.0
.text 484360 484240 -120 -0.0
lock-app qpg6100+debug (read only) 466008 465904 -104 -0.0
.text 460688 460584 -104 -0.0
telink lighting-app tlsr9518adk80d (read/write) 661606 661502 -104 -0.0
text 457328 457218 -110 -0.0
Full report (37 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 12ec702 b9c232b change % change
efr32 lighting-app BRD4161A (read only) 735400 734312 -1088 -0.1
(read/write) 114444 114444 0 0.0
.bss 112692 112692 0 0.0
.data 1752 1752 0 0.0
.text 735392 734304 -1088 -0.1
BRD4161A+rpc (read only) 722840 721752 -1088 -0.2
(read/write) 131052 131052 0 0.0
.bss 129196 129196 0 0.0
.data 1852 1852 0 0.0
.text 722832 721744 -1088 -0.2
lock-app BRD4161A (read only) 714684 713600 -1084 -0.2
(read/write) 112260 112260 0 0.0
.bss 110548 110548 0 0.0
.data 1712 1712 0 0.0
.text 714676 713592 -1084 -0.2
window-app BRD4161A (read only) 715596 714508 -1088 -0.2
(read/write) 112584 112584 0 0.0
.bss 110868 110868 0 0.0
.data 1716 1716 0 0.0
.text 715588 714500 -1088 -0.2
esp32 all-clusters-app c3devkit (read only) 880170 879858 -312 -0.0
(read/write) 1307552 1307104 -448 -0.0
.dram0.bss 58424 58424 0 0.0
.dram0.data 16464 16464 0 0.0
.flash.rodata 199424 198976 -448 -0.2
.flash.text 880170 879858 -312 -0.0
.iram0.text 57554 57554 0 0.0
m5stack (read only) 911115 910971 -144 -0.0
(read/write) 427312 426872 -440 -0.1
.dram0.bss 60920 60920 0 0.0
.dram0.data 32100 32100 0 0.0
.flash.rodata 208128 207688 -440 -0.2
.flash.text 911115 910971 -144 -0.0
.iram0.text 125115 125115 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 698232 698120 -112 -0.0
.bss 77688 77688 0 0.0
.data 1900 1900 0 0.0
.text 612844 612732 -112 -0.0
lock-app k32w061+debug (read/write) 590524 590412 -112 -0.0
.bss 68188 68188 0 0.0
.data 1864 1864 0 0.0
.text 514672 514560 -112 -0.0
shell k32w061+debug (read/write) 424772 424772 0 0.0
.bss 63280 63280 0 0.0
.data 672 672 0 0.0
.text 359116 359116 0 0.0
linux all-clusters-app debug (read only) 1684105 1681705 -2400 -0.1
(read/write) 118992 118928 -64 -0.1
.bss 50608 50544 -64 -0.1
.data 1010 1010 0 0.0
.data.rel.ro 62112 62112 0 0.0
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 137845 136853 -992 -0.7
.text 1413202 1411794 -1408 -0.1
bridge-app debug+rpc (read only) 1278533 1276133 -2400 -0.2
(read/write) 84104 84040 -64 -0.1
.bss 50768 50704 -64 -0.1
.data 976 976 0 0.0
.data.rel.ro 27368 27368 0 0.0
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 400 400 0 0.0
.rodata 109604 108612 -992 -0.9
.text 1073685 1072277 -1408 -0.1
chip-tool debug (read only) 4312925 4310509 -2416 -0.1
(read/write) 123552 123488 -64 -0.1
.bss 17680 17616 -64 -0.4
.data 1584 1584 0 0.0
.data.rel.ro 98880 98880 0 0.0
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 424 424 0 0.0
.rodata 217488 216528 -960 -0.4
.text 3829781 3828325 -1456 -0.0
lighting-app debug+rpc (read only) 1537505 1535105 -2400 -0.2
(read/write) 100976 100912 -64 -0.1
.bss 40152 40088 -64 -0.2
.data 1106 1106 0 0.0
.data.rel.ro 54448 54448 0 0.0
.dynamic 608 608 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 528 528 0 0.0
.rodata 127761 126769 -992 -0.8
.text 1277362 1275954 -1408 -0.1
ota-provider-app debug (read only) 1236425 1234025 -2400 -0.2
(read/write) 67072 67008 -64 -0.1
.bss 36608 36544 -64 -0.2
.data 752 752 0 0.0
.data.rel.ro 24616 24616 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 440 440 0 0.0
.rodata 110376 109384 -992 -0.9
.text 1029922 1028514 -1408 -0.1
ota-requestor-app debug (read only) 1293697 1291265 -2432 -0.2
(read/write) 76392 76328 -64 -0.1
.bss 44864 44800 -64 -0.1
.data 816 816 0 0.0
.data.rel.ro 25576 25576 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 512 512 0 0.0
.rodata 121600 120576 -1024 -0.8
.text 1074306 1072898 -1408 -0.1
shell debug (read only) 785041 785041 0 0.0
(read/write) 57664 57664 0 0.0
.bss 16072 16072 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36848 36848 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 336 336 0 0.0
.rodata 77295 77295 0 0.0
.text 606210 606210 0 0.0
tv-app debug (read only) 1770905 1768537 -2368 -0.1
(read/write) 288536 288472 -64 -0.0
.bss 222192 222128 -64 -0.0
.data 2032 2032 0 0.0
.data.rel.ro 58672 58672 0 0.0
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 608 608 0 0.0
.rodata 153176 152216 -960 -0.6
.text 1475826 1474418 -1408 -0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2293608 2293544 -64 -0.0
.bss 179796 179796 0 0.0
.data 5216 5216 0 0.0
.heap 851432 851432 0 0.0
.text 1256208 1256144 -64 -0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2272736 2272616 -120 -0.0
.bss 171836 171836 0 0.0
.data 5568 5568 0 0.0
.heap 859040 859040 0 0.0
.text 1235336 1235216 -120 -0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2250392 2250336 -56 -0.0
.bss 170740 170740 0 0.0
.data 5552 5552 0 0.0
.heap 860152 860152 0 0.0
.text 1212992 1212936 -56 -0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2048328 2048328 0 0.0
.bss 156232 156232 0 0.0
.data 4968 4968 0 0.0
.heap 875248 875248 0 0.0
.text 1010928 1010928 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 860175 860079 -96 -0.0
bss 111148 111148 0 0.0
rodata 96360 96360 0 0.0
text 577052 576944 -108 -0.0
nrf52840dk_nrf52840+rpc (read/write) 820999 820903 -96 -0.0
bss 107392 107392 0 0.0
rodata 87136 87136 0 0.0
text 550224 550120 -104 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 785218 785106 -112 -0.0
bss 112524 112524 0 0.0
rodata 91604 91604 0 0.0
text 506520 506412 -108 -0.0
lock-app nrf52840dk_nrf52840 (read/write) 836883 836771 -112 -0.0
bss 110184 110184 0 0.0
rodata 92716 92716 0 0.0
text 558532 558424 -108 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 762178 762066 -112 -0.0
bss 111596 111596 0 0.0
rodata 88020 88020 0 0.0
text 488092 487984 -108 -0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497323 497323 0 0.0
bss 51824 51824 0 0.0
rodata 45776 45776 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 842863 842751 -112 -0.0
bss 110320 110320 0 0.0
rodata 94424 94424 0 0.0
text 562588 562484 -104 -0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 836739 836627 -112 -0.0
bss 110220 110220 0 0.0
rodata 92716 92716 0 0.0
text 558268 558160 -108 -0.0
shell nrf52840dk_nrf52840 (read/write) 775903 775903 0 0.0
bss 109096 109096 0 0.0
rodata 72404 72404 0 0.0
text 519792 519792 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 690906 690906 0 0.0
bss 110080 110080 0 0.0
rodata 67044 67044 0 0.0
text 440400 440400 0 0.0
p6 lock-app default (read/write) 2166560 2165464 -1096 -0.1
.bss 66184 66184 0 0.0
.data 2416 2416 0 0.0
.heap 964744 964744 0 0.0
.text 1124824 1123728 -1096 -0.1
qpg lighting-app qpg6100+debug (read only) 489680 489560 -120 -0.0
(read/write) 114144 114144 0 0.0
.bss 50320 50320 0 0.0
.data 1000 1000 0 0.0
.text 484360 484240 -120 -0.0
lock-app qpg6100+debug (read only) 466008 465904 -104 -0.0
(read/write) 114140 114140 0 0.0
.bss 49272 49272 0 0.0
.data 956 956 0 0.0
.text 460688 460584 -104 -0.0
persistent-storage-app qpg6100+debug (read only) 155820 155820 0 0.0
(read/write) 114140 114140 0 0.0
.bss 27752 27752 0 0.0
.data 372 372 0 0.0
.text 150500 150500 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 661606 661502 -104 -0.0
bss 68960 68960 0 0.0
noinit 33216 33216 0 0.0
text 457328 457218 -110 -0.0

@erjiaqing erjiaqing force-pushed the im/cluster-info-wildcard branch from b9c232b to bd5330b Compare November 3, 2021 01:08
@github-actions
Copy link

github-actions bot commented Nov 3, 2021 •
edited
Loading

PR #11115: Size comparison from c9db3dc to bd5330b

Decreases (22 builds for efr32, esp32, k32w, mbed, nrfconnect, p6, qpg, telink)
platform target config section c9db3dc bd5330b change % change
efr32 lighting-app BRD4161A (read only) 737248 736144 -1104 -0.1
.text 737240 736136 -1104 -0.1
BRD4161A+rpc (read only) 724672 723584 -1088 -0.2
.text 724664 723576 -1088 -0.2
lock-app BRD4161A (read only) 716528 715428 -1100 -0.2
(read/write) 112436 112432 -4 -0.0
.text 716520 715420 -1100 -0.2
window-app BRD4161A (read only) 717428 716324 -1104 -0.2
.text 717420 716316 -1104 -0.2
esp32 all-clusters-app c3devkit (read only) 880718 880406 -312 -0.0
(read/write) 1308080 1307624 -456 -0.0
.flash.rodata 199776 199320 -456 -0.2
.flash.text 880718 880406 -312 -0.0
m5stack (read only) 911895 911759 -136 -0.0
(read/write) 427852 427404 -448 -0.1
.flash.rodata 208476 208028 -448 -0.2
.flash.text 911895 911759 -136 -0.0
k32w lighting-app k32w061+se05x+release (read/write) 699528 699416 -112 -0.0
.text 613968 613856 -112 -0.0
lock-app k32w061+debug (read/write) 591836 591724 -112 -0.0
.text 515796 515684 -112 -0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2293216 2293152 -64 -0.0
.text 1255816 1255752 -64 -0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2272216 2272088 -128 -0.0
.text 1234816 1234688 -128 -0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2249872 2249808 -64 -0.0
.text 1212472 1212408 -64 -0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 861395 861299 -96 -0.0
text 577692 577588 -104 -0.0
nrf52840dk_nrf52840+rpc (read/write) 822267 822155 -112 -0.0
text 550864 550760 -104 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 786434 786322 -112 -0.0
text 507152 507048 -104 -0.0
lock-app nrf52840dk_nrf52840 (read/write) 838099 838003 -96 -0.0
text 559168 559064 -104 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 763398 763302 -96 -0.0
text 488720 488616 -104 -0.0
pump-app nrf52840dk_nrf52840 (read/write) 844211 844115 -96 -0.0
text 563348 563244 -104 -0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 837955 837859 -96 -0.0
text 558904 558800 -104 -0.0
p6 lock-app default (read/write) 2168104 2167024 -1080 -0.0
.text 1126368 1125288 -1080 -0.1
qpg lighting-app qpg6100+debug (read only) 490784 490696 -88 -0.0
.text 485464 485376 -88 -0.0
lock-app qpg6100+debug (read only) 467120 467016 -104 -0.0
.text 461800 461696 -104 -0.0
telink lighting-app tlsr9518adk80d (read/write) 662894 662790 -104 -0.0
text 458028 457920 -108 -0.0
Full report (29 builds for efr32, esp32, k32w, mbed, nrfconnect, p6, qpg, telink)
platform target config section c9db3dc bd5330b change % change
efr32 lighting-app BRD4161A (read only) 737248 736144 -1104 -0.1
(read/write) 114620 114620 0 0.0
.bss 112860 112860 0 0.0
.data 1756 1756 0 0.0
.text 737240 736136 -1104 -0.1
BRD4161A+rpc (read only) 724672 723584 -1088 -0.2
(read/write) 131220 131220 0 0.0
.bss 129364 129364 0 0.0
.data 1856 1856 0 0.0
.text 724664 723576 -1088 -0.2
lock-app BRD4161A (read only) 716528 715428 -1100 -0.2
(read/write) 112436 112432 -4 -0.0
.bss 110716 110716 0 0.0
.data 1716 1716 0 0.0
.text 716520 715420 -1100 -0.2
window-app BRD4161A (read only) 717428 716324 -1104 -0.2
(read/write) 112756 112756 0 0.0
.bss 111036 111036 0 0.0
.data 1720 1720 0 0.0
.text 717420 716316 -1104 -0.2
esp32 all-clusters-app c3devkit (read only) 880718 880406 -312 -0.0
(read/write) 1308080 1307624 -456 -0.0
.dram0.bss 58608 58608 0 0.0
.dram0.data 16464 16464 0 0.0
.flash.rodata 199776 199320 -456 -0.2
.flash.text 880718 880406 -312 -0.0
.iram0.text 57554 57554 0 0.0
m5stack (read only) 911895 911759 -136 -0.0
(read/write) 427852 427404 -448 -0.1
.dram0.bss 61112 61112 0 0.0
.dram0.data 32100 32100 0 0.0
.flash.rodata 208476 208028 -448 -0.2
.flash.text 911895 911759 -136 -0.0
.iram0.text 125115 125115 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 699528 699416 -112 -0.0
.bss 77856 77856 0 0.0
.data 1904 1904 0 0.0
.text 613968 613856 -112 -0.0
lock-app k32w061+debug (read/write) 591836 591724 -112 -0.0
.bss 68372 68372 0 0.0
.data 1868 1868 0 0.0
.text 515796 515684 -112 -0.0
shell k32w061+debug (read/write) 424916 424916 0 0.0
.bss 63296 63296 0 0.0
.data 668 668 0 0.0
.text 359248 359248 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2293216 2293152 -64 -0.0
.bss 179964 179964 0 0.0
.data 5216 5216 0 0.0
.heap 851264 851264 0 0.0
.text 1255816 1255752 -64 -0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2272216 2272088 -128 -0.0
.bss 172012 172012 0 0.0
.data 5568 5568 0 0.0
.heap 858864 858864 0 0.0
.text 1234816 1234688 -128 -0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2249872 2249808 -64 -0.0
.bss 170908 170908 0 0.0
.data 5560 5560 0 0.0
.heap 859976 859976 0 0.0
.text 1212472 1212408 -64 -0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2048496 2048496 0 0.0
.bss 156256 156256 0 0.0
.data 4960 4960 0 0.0
.heap 875232 875232 0 0.0
.text 1011096 1011096 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 861395 861299 -96 -0.0
bss 111320 111320 0 0.0
rodata 96772 96772 0 0.0
text 577692 577588 -104 -0.0
nrf52840dk_nrf52840+rpc (read/write) 822267 822155 -112 -0.0
bss 107560 107560 0 0.0
rodata 87564 87564 0 0.0
text 550864 550760 -104 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 786434 786322 -112 -0.0
bss 112696 112696 0 0.0
rodata 92028 92028 0 0.0
text 507152 507048 -104 -0.0
lock-app nrf52840dk_nrf52840 (read/write) 838099 838003 -96 -0.0
bss 110356 110356 0 0.0
rodata 93140 93140 0 0.0
text 559168 559064 -104 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 763398 763302 -96 -0.0
bss 111764 111764 0 0.0
rodata 88448 88448 0 0.0
text 488720 488616 -104 -0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497323 497323 0 0.0
bss 51824 51824 0 0.0
rodata 45776 45776 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 844211 844115 -96 -0.0
bss 110492 110492 0 0.0
rodata 94852 94852 0 0.0
text 563348 563244 -104 -0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 837955 837859 -96 -0.0
bss 110392 110392 0 0.0
rodata 93140 93140 0 0.0
text 558904 558800 -104 -0.0
shell nrf52840dk_nrf52840 (read/write) 775991 775991 0 0.0
bss 109112 109112 0 0.0
rodata 72412 72412 0 0.0
text 519884 519884 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 691026 691026 0 0.0
bss 110092 110092 0 0.0
rodata 67052 67052 0 0.0
text 440480 440480 0 0.0
p6 lock-app default (read/write) 2168104 2167024 -1080 -0.0
.bss 66360 66360 0 0.0
.data 2416 2416 0 0.0
.heap 964568 964568 0 0.0
.text 1126368 1125288 -1080 -0.1
qpg lighting-app qpg6100+debug (read only) 490784 490696 -88 -0.0
(read/write) 114140 114140 0 0.0
.bss 50416 50416 0 0.0
.data 1004 1004 0 0.0
.text 485464 485376 -88 -0.0
lock-app qpg6100+debug (read only) 467120 467016 -104 -0.0
(read/write) 114144 114144 0 0.0
.bss 49360 49360 0 0.0
.data 960 960 0 0.0
.text 461800 461696 -104 -0.0
persistent-storage-app qpg6100+debug (read only) 153212 153212 0 0.0
(read/write) 114140 114140 0 0.0
.bss 18336 18336 0 0.0
.data 356 356 0 0.0
.text 147892 147892 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 662894 662790 -104 -0.0
bss 69132 69132 0 0.0
noinit 33216 33216 0 0.0
text 458028 457920 -108 -0.0

@erjiaqing erjiaqing force-pushed the im/cluster-info-wildcard branch 2 times, most recently from e8d6592 to 096a9c2 Compare November 3, 2021 02:54
@todo
Copy link

todo bot commented Nov 3, 2021

MEIs (ClusterId and AttributeId) have a invalid pattern instead of a single invalid value, need to add separate

connectedhomeip/src/app/ReadHandler.cpp

Lines 339 to 349 in 096a9c2

// TODO: MEIs (ClusterId and AttributeId) have a invalid pattern instead of a single invalid value, need to add separate
// functions for checking if we have received valid values.
err = path.GetEndpointId(&(clusterInfo.mEndpointId));
if (err == CHIP_NO_ERROR)
{
VerifyOrExit(clusterInfo.mEndpointId != ClusterInfo::kInvalidEndpointId, CHIP_ERROR_IM_MALFORMED_ATTRIBUTE_PATH);
}
SuccessOrExit(err);
err = path.GetClusterId(&(clusterInfo.mClusterId));
if (err == CHIP_NO_ERROR)
{

This comment was generated by todo based on a TODO comment in 096a9c2 in #11115. cc @erjiaqing.

@github-actions
Copy link

github-actions bot commented Nov 3, 2021

PR #11115: Size comparison from d920345 to 096a9c2

Decreases (2 builds for p6, telink)
platform target config section d920345 096a9c2 change % change
p6 lock-app default (read/write) 2168104 2167024 -1080 -0.0
.text 1126368 1125288 -1080 -0.1
telink lighting-app tlsr9518adk80d (read/write) 662894 662798 -96 -0.0
text 458028 457930 -98 -0.0
Full report (2 builds for p6, telink)
platform target config section d920345 096a9c2 change % change
p6 lock-app default (read/write) 2168104 2167024 -1080 -0.0
.bss 66360 66360 0 0.0
.data 2416 2416 0 0.0
.heap 964568 964568 0 0.0
.text 1126368 1125288 -1080 -0.1
telink lighting-app tlsr9518adk80d (read/write) 662894 662798 -96 -0.0
bss 69132 69132 0 0.0
noinit 33216 33216 0 0.0
text 458028 457930 -98 -0.0

@erjiaqing erjiaqing force-pushed the im/cluster-info-wildcard branch from 096a9c2 to 9072d37 Compare November 3, 2021 03:15
@github-actions
Copy link

github-actions bot commented Nov 3, 2021 •
edited
Loading

PR #11115: Size comparison from d5810e5 to 9072d37

Increases (3 builds for mbed)
platform target config section d5810e5 9072d37 change % change
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2293224 2293336 112 0.0
.text 1255824 1255936 112 0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2272216 2272272 56 0.0
.text 1234816 1234872 56 0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2249872 2249992 120 0.0
.text 1212472 1212592 120 0.0
Decreases (27 builds for efr32, esp32, k32w, linux, nrfconnect, p6, qpg, telink)
platform target config section d5810e5 9072d37 change % change
efr32 lighting-app BRD4161A (read only) 737248 736160 -1088 -0.1
.text 737240 736152 -1088 -0.1
BRD4161A+rpc (read only) 724672 723584 -1088 -0.2
.text 724664 723576 -1088 -0.2
lock-app BRD4161A (read only) 716528 715444 -1084 -0.2
(read/write) 112436 112432 -4 -0.0
.text 716520 715436 -1084 -0.2
window-app BRD4161A (read only) 717428 716340 -1088 -0.2
.text 717420 716332 -1088 -0.2
esp32 all-clusters-app c3devkit (read only) 880742 880422 -320 -0.0
(read/write) 1308096 1307648 -448 -0.0
.flash.rodata 199776 199328 -448 -0.2
.flash.text 880742 880422 -320 -0.0
m5stack (read only) 911907 911727 -180 -0.0
(read/write) 427860 427420 -440 -0.1
.flash.rodata 208476 208036 -440 -0.2
.flash.text 911907 911727 -180 -0.0
k32w lighting-app k32w061+se05x+release (read/write) 699528 699416 -112 -0.0
.text 613968 613856 -112 -0.0
lock-app k32w061+debug (read/write) 591836 591724 -112 -0.0
.text 515796 515684 -112 -0.0
linux all-clusters-app debug (read only) 1690937 1688665 -2272 -0.1
(read/write) 119760 119696 -64 -0.1
.bss 51184 51120 -64 -0.1
.rodata 139829 138837 -992 -0.7
.text 1417714 1416434 -1280 -0.1
bridge-app debug+rpc (read only) 1287325 1285053 -2272 -0.2
(read/write) 69384 69320 -64 -0.1
.bss 35088 35024 -64 -0.2
.rodata 111460 110468 -992 -0.9
.text 1079973 1078693 -1280 -0.1
chip-tool debug (read only) 4351269 4348965 -2304 -0.1
(read/write) 124896 124832 -64 -0.1
.bss 18224 18160 -64 -0.4
.rodata 219560 218568 -992 -0.5
.text 3865669 3864357 -1312 -0.0
lighting-app debug+rpc (read only) 1543193 1540921 -2272 -0.1
(read/write) 101712 101648 -64 -0.1
.bss 40728 40664 -64 -0.2
.rodata 129553 128561 -992 -0.8
.text 1280946 1279666 -1280 -0.1
ota-provider-app debug (read only) 1243689 1241417 -2272 -0.2
(read/write) 67552 67488 -64 -0.1
.bss 37152 37088 -64 -0.2
.rodata 112360 111368 -992 -0.9
.text 1035250 1033970 -1280 -0.1
ota-requestor-app debug (read only) 1311049 1308777 -2272 -0.2
(read/write) 76872 76808 -64 -0.1
.bss 45408 45344 -64 -0.1
.rodata 123328 122336 -992 -0.8
.text 1089954 1088674 -1280 -0.1
tv-app debug (read only) 1810545 1808257 -2288 -0.1
(read/write) 289944 289880 -64 -0.0
.bss 222768 222704 -64 -0.0
.rodata 155640 154648 -992 -0.6
.text 1512642 1511346 -1296 -0.1
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 861395 861283 -112 -0.0
text 577692 577584 -108 -0.0
nrf52840dk_nrf52840+rpc (read/write) 822267 822155 -112 -0.0
text 550864 550760 -104 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 786434 786322 -112 -0.0
text 507152 507048 -104 -0.0
lock-app nrf52840dk_nrf52840 (read/write) 838099 837987 -112 -0.0
text 559168 559060 -108 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 763398 763302 -96 -0.0
text 488720 488616 -104 -0.0
pump-app nrf52840dk_nrf52840 (read/write) 844211 844099 -112 -0.0
text 563348 563240 -108 -0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 837955 837859 -96 -0.0
text 558904 558796 -108 -0.0
p6 all-clusters-app default (read/write) 2300752 2299664 -1088 -0.0
.text 1259016 1257928 -1088 -0.1
lock-app default (read/write) 2213744 2212680 -1064 -0.0
.text 1172008 1170944 -1064 -0.1
qpg lighting-app qpg6100+debug (read only) 490784 490688 -96 -0.0
.text 485464 485368 -96 -0.0
lock-app qpg6100+debug (read only) 467120 467008 -112 -0.0
.text 461800 461688 -112 -0.0
telink lighting-app tlsr9518adk80d (read/write) 662894 662782 -112 -0.0
text 458028 457912 -116 -0.0
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section d5810e5 9072d37 change % change
efr32 lighting-app BRD4161A (read only) 737248 736160 -1088 -0.1
(read/write) 114620 114620 0 0.0
.bss 112860 112860 0 0.0
.data 1756 1756 0 0.0
.text 737240 736152 -1088 -0.1
BRD4161A+rpc (read only) 724672 723584 -1088 -0.2
(read/write) 131220 131220 0 0.0
.bss 129364 129364 0 0.0
.data 1856 1856 0 0.0
.text 724664 723576 -1088 -0.2
lock-app BRD4161A (read only) 716528 715444 -1084 -0.2
(read/write) 112436 112432 -4 -0.0
.bss 110716 110716 0 0.0
.data 1716 1716 0 0.0
.text 716520 715436 -1084 -0.2
window-app BRD4161A (read only) 717428 716340 -1088 -0.2
(read/write) 112756 112756 0 0.0
.bss 111036 111036 0 0.0
.data 1720 1720 0 0.0
.text 717420 716332 -1088 -0.2
esp32 all-clusters-app c3devkit (read only) 880742 880422 -320 -0.0
(read/write) 1308096 1307648 -448 -0.0
.dram0.bss 58616 58616 0 0.0
.dram0.data 16464 16464 0 0.0
.flash.rodata 199776 199328 -448 -0.2
.flash.text 880742 880422 -320 -0.0
.iram0.text 57554 57554 0 0.0
m5stack (read only) 911907 911727 -180 -0.0
(read/write) 427860 427420 -440 -0.1
.dram0.bss 61120 61120 0 0.0
.dram0.data 32100 32100 0 0.0
.flash.rodata 208476 208036 -440 -0.2
.flash.text 911907 911727 -180 -0.0
.iram0.text 125115 125115 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 699528 699416 -112 -0.0
.bss 77856 77856 0 0.0
.data 1904 1904 0 0.0
.text 613968 613856 -112 -0.0
lock-app k32w061+debug (read/write) 591836 591724 -112 -0.0
.bss 68372 68372 0 0.0
.data 1868 1868 0 0.0
.text 515796 515684 -112 -0.0
shell k32w061+debug (read/write) 424916 424916 0 0.0
.bss 63296 63296 0 0.0
.data 668 668 0 0.0
.text 359248 359248 0 0.0
linux all-clusters-app debug (read only) 1690937 1688665 -2272 -0.1
(read/write) 119760 119696 -64 -0.1
.bss 51184 51120 -64 -0.1
.data 1042 1042 0 0.0
.data.rel.ro 62272 62272 0 0.0
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 139829 138837 -992 -0.7
.text 1417714 1416434 -1280 -0.1
bridge-app debug+rpc (read only) 1287325 1285053 -2272 -0.2
(read/write) 69384 69320 -64 -0.1
.bss 35088 35024 -64 -0.2
.data 1568 1568 0 0.0
.data.rel.ro 27768 27768 0 0.0
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 400 400 0 0.0
.rodata 111460 110468 -992 -0.9
.text 1079973 1078693 -1280 -0.1
chip-tool debug (read only) 4351269 4348965 -2304 -0.1
(read/write) 124896 124832 -64 -0.1
.bss 18224 18160 -64 -0.4
.data 2224 2224 0 0.0
.data.rel.ro 99040 99040 0 0.0
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 424 424 0 0.0
.rodata 219560 218568 -992 -0.5
.text 3865669 3864357 -1312 -0.0
lighting-app debug+rpc (read only) 1543193 1540921 -2272 -0.1
(read/write) 101712 101648 -64 -0.1
.bss 40728 40664 -64 -0.2
.data 1138 1138 0 0.0
.data.rel.ro 54560 54560 0 0.0
.dynamic 608 608 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 528 528 0 0.0
.rodata 129553 128561 -992 -0.8
.text 1280946 1279666 -1280 -0.1
ota-provider-app debug (read only) 1243689 1241417 -2272 -0.2
(read/write) 67552 67488 -64 -0.1
.bss 37152 37088 -64 -0.2
.data 752 752 0 0.0
.data.rel.ro 24568 24568 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 440 440 0 0.0
.rodata 112360 111368 -992 -0.9
.text 1035250 1033970 -1280 -0.1
ota-requestor-app debug (read only) 1311049 1308777 -2272 -0.2
(read/write) 76872 76808 -64 -0.1
.bss 45408 45344 -64 -0.1
.data 816 816 0 0.0
.data.rel.ro 25512 25512 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 512 512 0 0.0
.rodata 123328 122336 -992 -0.8
.text 1089954 1088674 -1280 -0.1
shell debug (read only) 786593 786593 0 0.0
(read/write) 57664 57664 0 0.0
.bss 16104 16104 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36816 36816 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 336 336 0 0.0
.rodata 77839 77839 0 0.0
.text 607266 607266 0 0.0
tv-app debug (read only) 1810545 1808257 -2288 -0.1
(read/write) 289944 289880 -64 -0.0
.bss 222768 222704 -64 -0.0
.data 2704 2704 0 0.0
.data.rel.ro 58824 58824 0 0.0
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 608 608 0 0.0
.rodata 155640 154648 -992 -0.6
.text 1512642 1511346 -1296 -0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2293224 2293336 112 0.0
.bss 179972 179972 0 0.0
.data 5216 5216 0 0.0
.heap 851256 851256 0 0.0
.text 1255824 1255936 112 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2272216 2272272 56 0.0
.bss 172012 172012 0 0.0
.data 5568 5568 0 0.0
.heap 858864 858864 0 0.0
.text 1234816 1234872 56 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2249872 2249992 120 0.0
.bss 170908 170908 0 0.0
.data 5560 5560 0 0.0
.heap 859976 859976 0 0.0
.text 1212472 1212592 120 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2048496 2048496 0 0.0
.bss 156256 156256 0 0.0
.data 4960 4960 0 0.0
.heap 875232 875232 0 0.0
.text 1011096 1011096 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 861395 861283 -112 -0.0
bss 111320 111320 0 0.0
rodata 96772 96772 0 0.0
text 577692 577584 -108 -0.0
nrf52840dk_nrf52840+rpc (read/write) 822267 822155 -112 -0.0
bss 107560 107560 0 0.0
rodata 87564 87564 0 0.0
text 550864 550760 -104 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 786434 786322 -112 -0.0
bss 112696 112696 0 0.0
rodata 92028 92028 0 0.0
text 507152 507048 -104 -0.0
lock-app nrf52840dk_nrf52840 (read/write) 838099 837987 -112 -0.0
bss 110356 110356 0 0.0
rodata 93140 93140 0 0.0
text 559168 559060 -108 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 763398 763302 -96 -0.0
bss 111764 111764 0 0.0
rodata 88448 88448 0 0.0
text 488720 488616 -104 -0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497323 497323 0 0.0
bss 51824 51824 0 0.0
rodata 45776 45776 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 844211 844099 -112 -0.0
bss 110492 110492 0 0.0
rodata 94852 94852 0 0.0
text 563348 563240 -108 -0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 837955 837859 -96 -0.0
bss 110392 110392 0 0.0
rodata 93140 93140 0 0.0
text 558904 558796 -108 -0.0
shell nrf52840dk_nrf52840 (read/write) 775991 775991 0 0.0
bss 109112 109112 0 0.0
rodata 72412 72412 0 0.0
text 519884 519884 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 691026 691026 0 0.0
bss 110092 110092 0 0.0
rodata 67052 67052 0 0.0
text 440480 440480 0 0.0
p6 all-clusters-app default (read/write) 2300752 2299664 -1088 -0.0
.bss 107912 107912 0 0.0
.data 2520 2520 0 0.0
.heap 922912 922912 0 0.0
.text 1259016 1257928 -1088 -0.1
lock-app default (read/write) 2213744 2212680 -1064 -0.0
.bss 95712 95712 0 0.0
.data 2392 2392 0 0.0
.heap 935240 935240 0 0.0
.text 1172008 1170944 -1064 -0.1
qpg lighting-app qpg6100+debug (read only) 490784 490688 -96 -0.0
(read/write) 114140 114140 0 0.0
.bss 50416 50416 0 0.0
.data 1004 1004 0 0.0
.text 485464 485368 -96 -0.0
lock-app qpg6100+debug (read only) 467120 467008 -112 -0.0
(read/write) 114144 114144 0 0.0
.bss 49360 49360 0 0.0
.data 960 960 0 0.0
.text 461800 461688 -112 -0.0
persistent-storage-app qpg6100+debug (read only) 153212 153212 0 0.0
(read/write) 114140 114140 0 0.0
.bss 18336 18336 0 0.0
.data 356 356 0 0.0
.text 147892 147892 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 662894 662782 -112 -0.0
bss 69132 69132 0 0.0
noinit 33216 33216 0 0.0
text 458028 457912 -116 -0.0

bzbarsky-apple
bzbarsky-apple requested changes Nov 3, 2021
View reviewed changes
src/app/ClusterInfo.h Outdated Show resolved Hide resolved
src/app/ClusterInfo.h Outdated Show resolved Hide resolved
src/app/ClusterInfo.h Outdated Show resolved Hide resolved
src/app/ClusterInfo.h Outdated Show resolved Hide resolved
src/app/ClusterInfo.h Outdated Show resolved Hide resolved
src/app/ReadClient.cpp Outdated Show resolved Hide resolved
src/app/ReadHandler.cpp Show resolved Hide resolved
src/app/ReadHandler.cpp Outdated Show resolved Hide resolved
src/app/WriteHandler.cpp Show resolved Hide resolved
src/app/WriteHandler.cpp Show resolved Hide resolved
@erjiaqing erjiaqing force-pushed the im/cluster-info-wildcard branch from 9072d37 to 3bd70d1 Compare November 4, 2021 02:05
@github-actions
Copy link

github-actions bot commented Nov 4, 2021 •
edited
Loading

PR #11115: Size comparison from ee7682d to 3bd70d1

Increases (3 builds for mbed)
platform target config section ee7682d 3bd70d1 change % change
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2293328 2293544 216 0.0
.text 1255928 1256144 216 0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2272760 2272976 216 0.0
.text 1235360 1235576 216 0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2250480 2250632 152 0.0
.text 1213080 1213232 152 0.0
Decreases (28 builds for efr32, esp32, k32w, linux, nrfconnect, p6, qpg, telink)
platform target config section ee7682d 3bd70d1 change % change
efr32 lighting-app BRD4161A (read only) 737432 736408 -1024 -0.1
.text 737424 736400 -1024 -0.1
BRD4161A+rpc (read only) 726628 725604 -1024 -0.1
.text 726620 725596 -1024 -0.1
lock-app BRD4161A (read only) 716696 715676 -1020 -0.1
(read/write) 112404 112400 -4 -0.0
.text 716688 715668 -1020 -0.1
window-app BRD4161A (read only) 717612 716572 -1040 -0.1
.text 717604 716564 -1040 -0.1
esp32 all-clusters-app c3devkit (read only) 880890 880598 -292 -0.0
(read/write) 1308120 1307672 -448 -0.0
.flash.rodata 199832 199384 -448 -0.2
.flash.text 880890 880598 -292 -0.0
m5stack (read only) 912007 911911 -96 -0.0
(read/write) 427876 427436 -440 -0.1
.flash.rodata 208524 208084 -440 -0.2
.flash.text 912007 911911 -96 -0.0
k32w lighting-app k32w061+se05x+release (read/write) 699648 699584 -64 -0.0
.text 614120 614056 -64 -0.0
lock-app k32w061+debug (read/write) 591956 591908 -48 -0.0
.text 515948 515900 -48 -0.0
shell k32w061+debug (read/write) 657904 657840 -64 -0.0
.text 571272 571208 -64 -0.0
linux all-clusters-app debug (read only) 1697761 1696065 -1696 -0.1
(read/write) 119696 119632 -64 -0.1
.bss 51120 51056 -64 -0.1
.rodata 140469 139477 -992 -0.7
.text 1423874 1423170 -704 -0.0
bridge-app debug+rpc (read only) 1292477 1290765 -1712 -0.1
(read/write) 69320 69256 -64 -0.1
.bss 35024 34960 -64 -0.2
.rodata 111780 110788 -992 -0.9
.text 1084805 1084085 -720 -0.1
chip-tool debug (read only) 4429253 4427541 -1712 -0.0
(read/write) 125888 125824 -64 -0.1
.bss 18224 18160 -64 -0.4
.rodata 226992 226032 -960 -0.4
.text 3933941 3933189 -752 -0.0
lighting-app debug+rpc (read only) 1553505 1551793 -1712 -0.1
(read/write) 102288 102224 -64 -0.1
.bss 40664 40600 -64 -0.2
.rodata 130449 129457 -992 -0.8
.text 1289474 1288754 -720 -0.1
ota-provider-app debug (read only) 1251761 1250049 -1712 -0.1
(read/write) 67488 67424 -64 -0.1
.bss 37088 37024 -64 -0.2
.rodata 113032 112040 -992 -0.9
.text 1042626 1041906 -720 -0.1
ota-requestor-app debug (read only) 1329497 1327769 -1728 -0.1
(read/write) 76744 76680 -64 -0.1
.bss 45216 45152 -64 -0.1
.rodata 124464 123440 -1024 -0.8
.text 1106978 1106274 -704 -0.1
tv-app debug (read only) 1817113 1815401 -1712 -0.1
(read/write) 289912 289848 -64 -0.0
.bss 222736 222672 -64 -0.0
.rodata 156040 155048 -992 -0.6
.text 1518786 1518066 -720 -0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 861623 861559 -64 -0.0
text 577912 577848 -64 -0.0
nrf52840dk_nrf52840+rpc (read/write) 824003 823939 -64 -0.0
text 552100 552032 -68 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 786662 786582 -80 -0.0
text 507372 507304 -68 -0.0
lock-app nrf52840dk_nrf52840 (read/write) 838331 838267 -64 -0.0
text 559388 559324 -64 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 763626 763562 -64 -0.0
text 488940 488872 -68 -0.0
pump-app nrf52840dk_nrf52840 (read/write) 844439 844375 -64 -0.0
text 563568 563504 -64 -0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 838183 838119 -64 -0.0
text 559124 559060 -64 -0.0
p6 all-clusters-app default (read/write) 2301080 2300056 -1024 -0.0
.text 1259344 1258320 -1024 -0.1
lock-app default (read/write) 2213928 2212912 -1016 -0.0
.text 1172192 1171176 -1016 -0.1
qpg lighting-app qpg6100+debug (read only) 490932 490884 -48 -0.0
.text 485612 485564 -48 -0.0
lock-app qpg6100+debug (read only) 467280 467208 -72 -0.0
.text 461960 461888 -72 -0.0
telink lighting-app tlsr9518adk80d (read/write) 663086 662998 -88 -0.0
text 458206 458122 -84 -0.0
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section ee7682d 3bd70d1 change % change
efr32 lighting-app BRD4161A (read only) 737432 736408 -1024 -0.1
(read/write) 114588 114588 0 0.0
.bss 112828 112828 0 0.0
.data 1756 1756 0 0.0
.text 737424 736400 -1024 -0.1
BRD4161A+rpc (read only) 726628 725604 -1024 -0.1
(read/write) 131204 131204 0 0.0
.bss 129332 129332 0 0.0
.data 1872 1872 0 0.0
.text 726620 725596 -1024 -0.1
lock-app BRD4161A (read only) 716696 715676 -1020 -0.1
(read/write) 112404 112400 -4 -0.0
.bss 110684 110684 0 0.0
.data 1716 1716 0 0.0
.text 716688 715668 -1020 -0.1
window-app BRD4161A (read only) 717612 716572 -1040 -0.1
(read/write) 112724 112724 0 0.0
.bss 111004 111004 0 0.0
.data 1720 1720 0 0.0
.text 717604 716564 -1040 -0.1
esp32 all-clusters-app c3devkit (read only) 880890 880598 -292 -0.0
(read/write) 1308120 1307672 -448 -0.0
.dram0.bss 58584 58584 0 0.0
.dram0.data 16464 16464 0 0.0
.flash.rodata 199832 199384 -448 -0.2
.flash.text 880890 880598 -292 -0.0
.iram0.text 57554 57554 0 0.0
m5stack (read only) 912007 911911 -96 -0.0
(read/write) 427876 427436 -440 -0.1
.dram0.bss 61088 61088 0 0.0
.dram0.data 32100 32100 0 0.0
.flash.rodata 208524 208084 -440 -0.2
.flash.text 912007 911911 -96 -0.0
.iram0.text 125115 125115 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 699648 699584 -64 -0.0
.bss 77824 77824 0 0.0
.data 1904 1904 0 0.0
.text 614120 614056 -64 -0.0
lock-app k32w061+debug (read/write) 591956 591908 -48 -0.0
.bss 68340 68340 0 0.0
.data 1868 1868 0 0.0
.text 515948 515900 -48 -0.0
shell k32w061+debug (read/write) 657904 657840 -64 -0.0
.bss 78992 78992 0 0.0
.data 1840 1840 0 0.0
.text 571272 571208 -64 -0.0
linux all-clusters-app debug (read only) 1697761 1696065 -1696 -0.1
(read/write) 119696 119632 -64 -0.1
.bss 51120 51056 -64 -0.1
.data 1042 1042 0 0.0
.data.rel.ro 62272 62272 0 0.0
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 140469 139477 -992 -0.7
.text 1423874 1423170 -704 -0.0
bridge-app debug+rpc (read only) 1292477 1290765 -1712 -0.1
(read/write) 69320 69256 -64 -0.1
.bss 35024 34960 -64 -0.2
.data 1568 1568 0 0.0
.data.rel.ro 27768 27768 0 0.0
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 400 400 0 0.0
.rodata 111780 110788 -992 -0.9
.text 1084805 1084085 -720 -0.1
chip-tool debug (read only) 4429253 4427541 -1712 -0.0
(read/write) 125888 125824 -64 -0.1
.bss 18224 18160 -64 -0.4
.data 2224 2224 0 0.0
.data.rel.ro 100032 100032 0 0.0
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 424 424 0 0.0
.rodata 226992 226032 -960 -0.4
.text 3933941 3933189 -752 -0.0
lighting-app debug+rpc (read only) 1553505 1551793 -1712 -0.1
(read/write) 102288 102224 -64 -0.1
.bss 40664 40600 -64 -0.2
.data 1170 1170 0 0.0
.data.rel.ro 55168 55168 0 0.0
.dynamic 608 608 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 528 528 0 0.0
.rodata 130449 129457 -992 -0.8
.text 1289474 1288754 -720 -0.1
ota-provider-app debug (read only) 1251761 1250049 -1712 -0.1
(read/write) 67488 67424 -64 -0.1
.bss 37088 37024 -64 -0.2
.data 752 752 0 0.0
.data.rel.ro 24568 24568 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 440 440 0 0.0
.rodata 113032 112040 -992 -0.9
.text 1042626 1041906 -720 -0.1
ota-requestor-app debug (read only) 1329497 1327769 -1728 -0.1
(read/write) 76744 76680 -64 -0.1
.bss 45216 45152 -64 -0.1
.data 816 816 0 0.0
.data.rel.ro 25576 25576 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 512 512 0 0.0
.rodata 124464 123440 -1024 -0.8
.text 1106978 1106274 -704 -0.1
shell debug (read only) 786641 786641 0 0.0
(read/write) 57600 57600 0 0.0
.bss 16040 16040 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36816 36816 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 336 336 0 0.0
.rodata 77839 77839 0 0.0
.text 607314 607314 0 0.0
tv-app debug (read only) 1817113 1815401 -1712 -0.1
(read/write) 289912 289848 -64 -0.0
.bss 222736 222672 -64 -0.0
.data 2704 2704 0 0.0
.data.rel.ro 58824 58824 0 0.0
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 608 608 0 0.0
.rodata 156040 155048 -992 -0.6
.text 1518786 1518066 -720 -0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2293328 2293544 216 0.0
.bss 179940 179940 0 0.0
.data 5216 5216 0 0.0
.heap 851288 851288 0 0.0
.text 1255928 1256144 216 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2272760 2272976 216 0.0
.bss 171980 171980 0 0.0
.data 5568 5568 0 0.0
.heap 858896 858896 0 0.0
.text 1235360 1235576 216 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2250480 2250632 152 0.0
.bss 170876 170876 0 0.0
.data 5560 5560 0 0.0
.heap 860008 860008 0 0.0
.text 1213080 1213232 152 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2048368 2048368 0 0.0
.bss 156224 156224 0 0.0
.data 4960 4960 0 0.0
.heap 875264 875264 0 0.0
.text 1010968 1010968 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 861623 861559 -64 -0.0
bss 111288 111288 0 0.0
rodata 96808 96808 0 0.0
text 577912 577848 -64 -0.0
nrf52840dk_nrf52840+rpc (read/write) 824003 823939 -64 -0.0
bss 107640 107640 0 0.0
rodata 87988 87988 0 0.0
text 552100 552032 -68 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 786662 786582 -80 -0.0
bss 112664 112664 0 0.0
rodata 92064 92064 0 0.0
text 507372 507304 -68 -0.0
lock-app nrf52840dk_nrf52840 (read/write) 838331 838267 -64 -0.0
bss 110324 110324 0 0.0
rodata 93180 93180 0 0.0
text 559388 559324 -64 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 763626 763562 -64 -0.0
bss 111732 111732 0 0.0
rodata 88484 88484 0 0.0
text 488940 488872 -68 -0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497323 497323 0 0.0
bss 51824 51824 0 0.0
rodata 45776 45776 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 844439 844375 -64 -0.0
bss 110460 110460 0 0.0
rodata 94888 94888 0 0.0
text 563568 563504 -64 -0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 838183 838119 -64 -0.0
bss 110360 110360 0 0.0
rodata 93176 93176 0 0.0
text 559124 559060 -64 -0.0
shell nrf52840dk_nrf52840 (read/write) 775975 775975 0 0.0
bss 109080 109080 0 0.0
rodata 72412 72412 0 0.0
text 519904 519904 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 691010 691010 0 0.0
bss 110060 110060 0 0.0
rodata 67052 67052 0 0.0
text 440496 440496 0 0.0
p6 all-clusters-app default (read/write) 2301080 2300056 -1024 -0.0
.bss 107880 107880 0 0.0
.data 2520 2520 0 0.0
.heap 922944 922944 0 0.0
.text 1259344 1258320 -1024 -0.1
lock-app default (read/write) 2213928 2212912 -1016 -0.0
.bss 95680 95680 0 0.0
.data 2392 2392 0 0.0
.heap 935272 935272 0 0.0
.text 1172192 1171176 -1016 -0.1
qpg lighting-app qpg6100+debug (read only) 490932 490884 -48 -0.0
(read/write) 114140 114140 0 0.0
.bss 50968 50968 0 0.0
.data 1004 1004 0 0.0
.text 485612 485564 -48 -0.0
lock-app qpg6100+debug (read only) 467280 467208 -72 -0.0
(read/write) 114144 114144 0 0.0
.bss 49912 49912 0 0.0
.data 960 960 0 0.0
.text 461960 461888 -72 -0.0
persistent-storage-app qpg6100+debug (read only) 153212 153212 0 0.0
(read/write) 114140 114140 0 0.0
.bss 18920 18920 0 0.0
.data 356 356 0 0.0
.text 147892 147892 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 663086 662998 -88 -0.0
bss 69100 69100 0 0.0
noinit 33216 33216 0 0.0
text 458206 458122 -84 -0.0

bzbarsky-apple
bzbarsky-apple reviewed Nov 4, 2021
View reviewed changes
src/app/MessageDef/Parser.h Outdated Show resolved Hide resolved
src/app/ReadHandler.cpp Outdated Show resolved Hide resolved
src/app/ReadHandler.cpp Outdated Show resolved Hide resolved
src/app/ReadHandler.cpp Outdated Show resolved Hide resolved
src/app/ReadHandler.cpp Outdated Show resolved Hide resolved
src/app/ReadHandler.cpp Outdated Show resolved Hide resolved
src/app/ClusterInfo.h Show resolved Hide resolved
@erjiaqing erjiaqing force-pushed the im/cluster-info-wildcard branch from 3bd70d1 to 485ad7a Compare November 4, 2021 03:57
bzbarsky-apple
bzbarsky-apple approved these changes Nov 4, 2021
View reviewed changes
Copy link
Contributor

@bzbarsky-apple bzbarsky-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@github-actions
Copy link

github-actions bot commented Nov 4, 2021 •
edited
Loading

PR #11115: Size comparison from ee7682d to 7434468

Increases (3 builds for mbed)
platform target config section ee7682d 7434468 change % change
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2293328 2293560 232 0.0
.text 1255928 1256160 232 0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2272760 2272992 232 0.0
.text 1235360 1235592 232 0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2250480 2250712 232 0.0
.text 1213080 1213312 232 0.0
Decreases (28 builds for efr32, esp32, k32w, linux, nrfconnect, p6, qpg, telink)
platform target config section ee7682d 7434468 change % change
efr32 lighting-app BRD4161A (read only) 737432 736424 -1008 -0.1
.text 737424 736416 -1008 -0.1
BRD4161A+rpc (read only) 726628 725620 -1008 -0.1
.text 726620 725612 -1008 -0.1
lock-app BRD4161A (read only) 716696 715692 -1004 -0.1
(read/write) 112404 112400 -4 -0.0
.text 716688 715684 -1004 -0.1
window-app BRD4161A (read only) 717612 716588 -1024 -0.1
.text 717604 716580 -1024 -0.1
esp32 all-clusters-app c3devkit (read only) 880890 880606 -284 -0.0
(read/write) 1308120 1307672 -448 -0.0
.flash.rodata 199832 199384 -448 -0.2
.flash.text 880890 880606 -284 -0.0
m5stack (read only) 912007 911847 -160 -0.0
(read/write) 427876 427436 -440 -0.1
.flash.rodata 208524 208084 -440 -0.2
.flash.text 912007 911847 -160 -0.0
k32w lighting-app k32w061+se05x+release (read/write) 699648 699600 -48 -0.0
.text 614120 614072 -48 -0.0
lock-app k32w061+debug (read/write) 591956 591908 -48 -0.0
.text 515948 515900 -48 -0.0
shell k32w061+debug (read/write) 657904 657840 -64 -0.0
.text 571272 571208 -64 -0.0
linux all-clusters-app debug (read only) 1697761 1696161 -1600 -0.1
(read/write) 119696 119632 -64 -0.1
.bss 51120 51056 -64 -0.1
.rodata 140469 139477 -992 -0.7
.text 1423874 1423266 -608 -0.0
bridge-app debug+rpc (read only) 1292477 1290877 -1600 -0.1
(read/write) 69320 69256 -64 -0.1
.bss 35024 34960 -64 -0.2
.rodata 111780 110788 -992 -0.9
.text 1084805 1084197 -608 -0.1
chip-tool debug (read only) 4429253 4427637 -1616 -0.0
(read/write) 125888 125824 -64 -0.1
.bss 18224 18160 -64 -0.4
.rodata 226992 226032 -960 -0.4
.text 3933941 3933285 -656 -0.0
lighting-app debug+rpc (read only) 1553505 1551889 -1616 -0.1
(read/write) 102288 102224 -64 -0.1
.bss 40664 40600 -64 -0.2
.rodata 130449 129457 -992 -0.8
.text 1289474 1288850 -624 -0.0
ota-provider-app debug (read only) 1251761 1250145 -1616 -0.1
(read/write) 67488 67424 -64 -0.1
.bss 37088 37024 -64 -0.2
.rodata 113032 112040 -992 -0.9
.text 1042626 1042002 -624 -0.1
ota-requestor-app debug (read only) 1329497 1327865 -1632 -0.1
(read/write) 76744 76680 -64 -0.1
.bss 45216 45152 -64 -0.1
.rodata 124464 123440 -1024 -0.8
.text 1106978 1106370 -608 -0.1
tv-app debug (read only) 1817113 1815513 -1600 -0.1
(read/write) 289912 289848 -64 -0.0
.bss 222736 222672 -64 -0.0
.rodata 156040 155048 -992 -0.6
.text 1518786 1518178 -608 -0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 861623 861575 -48 -0.0
text 577912 577860 -52 -0.0
nrf52840dk_nrf52840+rpc (read/write) 824003 823955 -48 -0.0
text 552100 552044 -56 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 786662 786598 -64 -0.0
text 507372 507316 -56 -0.0
lock-app nrf52840dk_nrf52840 (read/write) 838331 838283 -48 -0.0
text 559388 559336 -52 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 763626 763562 -64 -0.0
text 488940 488884 -56 -0.0
pump-app nrf52840dk_nrf52840 (read/write) 844439 844391 -48 -0.0
text 563568 563516 -52 -0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 838183 838135 -48 -0.0
text 559124 559072 -52 -0.0
p6 all-clusters-app default (read/write) 2301080 2300056 -1024 -0.0
.text 1259344 1258320 -1024 -0.1
lock-app default (read/write) 2213928 2212912 -1016 -0.0
.text 1172192 1171176 -1016 -0.1
qpg lighting-app qpg6100+debug (read only) 490932 490892 -40 -0.0
.text 485612 485572 -40 -0.0
lock-app qpg6100+debug (read only) 467280 467224 -56 -0.0
.text 461960 461904 -56 -0.0
telink lighting-app tlsr9518adk80d (read/write) 663086 663006 -80 -0.0
text 458206 458130 -76 -0.0
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section ee7682d 7434468 change % change
efr32 lighting-app BRD4161A (read only) 737432 736424 -1008 -0.1
(read/write) 114588 114588 0 0.0
.bss 112828 112828 0 0.0
.data 1756 1756 0 0.0
.text 737424 736416 -1008 -0.1
BRD4161A+rpc (read only) 726628 725620 -1008 -0.1
(read/write) 131204 131204 0 0.0
.bss 129332 129332 0 0.0
.data 1872 1872 0 0.0
.text 726620 725612 -1008 -0.1
lock-app BRD4161A (read only) 716696 715692 -1004 -0.1
(read/write) 112404 112400 -4 -0.0
.bss 110684 110684 0 0.0
.data 1716 1716 0 0.0
.text 716688 715684 -1004 -0.1
window-app BRD4161A (read only) 717612 716588 -1024 -0.1
(read/write) 112724 112724 0 0.0
.bss 111004 111004 0 0.0
.data 1720 1720 0 0.0
.text 717604 716580 -1024 -0.1
esp32 all-clusters-app c3devkit (read only) 880890 880606 -284 -0.0
(read/write) 1308120 1307672 -448 -0.0
.dram0.bss 58584 58584 0 0.0
.dram0.data 16464 16464 0 0.0
.flash.rodata 199832 199384 -448 -0.2
.flash.text 880890 880606 -284 -0.0
.iram0.text 57554 57554 0 0.0
m5stack (read only) 912007 911847 -160 -0.0
(read/write) 427876 427436 -440 -0.1
.dram0.bss 61088 61088 0 0.0
.dram0.data 32100 32100 0 0.0
.flash.rodata 208524 208084 -440 -0.2
.flash.text 912007 911847 -160 -0.0
.iram0.text 125115 125115 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 699648 699600 -48 -0.0
.bss 77824 77824 0 0.0
.data 1904 1904 0 0.0
.text 614120 614072 -48 -0.0
lock-app k32w061+debug (read/write) 591956 591908 -48 -0.0
.bss 68340 68340 0 0.0
.data 1868 1868 0 0.0
.text 515948 515900 -48 -0.0
shell k32w061+debug (read/write) 657904 657840 -64 -0.0
.bss 78992 78992 0 0.0
.data 1840 1840 0 0.0
.text 571272 571208 -64 -0.0
linux all-clusters-app debug (read only) 1697761 1696161 -1600 -0.1
(read/write) 119696 119632 -64 -0.1
.bss 51120 51056 -64 -0.1
.data 1042 1042 0 0.0
.data.rel.ro 62272 62272 0 0.0
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 140469 139477 -992 -0.7
.text 1423874 1423266 -608 -0.0
bridge-app debug+rpc (read only) 1292477 1290877 -1600 -0.1
(read/write) 69320 69256 -64 -0.1
.bss 35024 34960 -64 -0.2
.data 1568 1568 0 0.0
.data.rel.ro 27768 27768 0 0.0
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 400 400 0 0.0
.rodata 111780 110788 -992 -0.9
.text 1084805 1084197 -608 -0.1
chip-tool debug (read only) 4429253 4427637 -1616 -0.0
(read/write) 125888 125824 -64 -0.1
.bss 18224 18160 -64 -0.4
.data 2224 2224 0 0.0
.data.rel.ro 100032 100032 0 0.0
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 424 424 0 0.0
.rodata 226992 226032 -960 -0.4
.text 3933941 3933285 -656 -0.0
lighting-app debug+rpc (read only) 1553505 1551889 -1616 -0.1
(read/write) 102288 102224 -64 -0.1
.bss 40664 40600 -64 -0.2
.data 1170 1170 0 0.0
.data.rel.ro 55168 55168 0 0.0
.dynamic 608 608 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 528 528 0 0.0
.rodata 130449 129457 -992 -0.8
.text 1289474 1288850 -624 -0.0
ota-provider-app debug (read only) 1251761 1250145 -1616 -0.1
(read/write) 67488 67424 -64 -0.1
.bss 37088 37024 -64 -0.2
.data 752 752 0 0.0
.data.rel.ro 24568 24568 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 440 440 0 0.0
.rodata 113032 112040 -992 -0.9
.text 1042626 1042002 -624 -0.1
ota-requestor-app debug (read only) 1329497 1327865 -1632 -0.1
(read/write) 76744 76680 -64 -0.1
.bss 45216 45152 -64 -0.1
.data 816 816 0 0.0
.data.rel.ro 25576 25576 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 512 512 0 0.0
.rodata 124464 123440 -1024 -0.8
.text 1106978 1106370 -608 -0.1
shell debug (read only) 786641 786641 0 0.0
(read/write) 57600 57600 0 0.0
.bss 16040 16040 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36816 36816 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 336 336 0 0.0
.rodata 77839 77839 0 0.0
.text 607314 607314 0 0.0
tv-app debug (read only) 1817113 1815513 -1600 -0.1
(read/write) 289912 289848 -64 -0.0
.bss 222736 222672 -64 -0.0
.data 2704 2704 0 0.0
.data.rel.ro 58824 58824 0 0.0
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 608 608 0 0.0
.rodata 156040 155048 -992 -0.6
.text 1518786 1518178 -608 -0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2293328 2293560 232 0.0
.bss 179940 179940 0 0.0
.data 5216 5216 0 0.0
.heap 851288 851288 0 0.0
.text 1255928 1256160 232 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2272760 2272992 232 0.0
.bss 171980 171980 0 0.0
.data 5568 5568 0 0.0
.heap 858896 858896 0 0.0
.text 1235360 1235592 232 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2250480 2250712 232 0.0
.bss 170876 170876 0 0.0
.data 5560 5560 0 0.0
.heap 860008 860008 0 0.0
.text 1213080 1213312 232 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2048368 2048368 0 0.0
.bss 156224 156224 0 0.0
.data 4960 4960 0 0.0
.heap 875264 875264 0 0.0
.text 1010968 1010968 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 861623 861575 -48 -0.0
bss 111288 111288 0 0.0
rodata 96808 96808 0 0.0
text 577912 577860 -52 -0.0
nrf52840dk_nrf52840+rpc (read/write) 824003 823955 -48 -0.0
bss 107640 107640 0 0.0
rodata 87988 87988 0 0.0
text 552100 552044 -56 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 786662 786598 -64 -0.0
bss 112664 112664 0 0.0
rodata 92064 92064 0 0.0
text 507372 507316 -56 -0.0
lock-app nrf52840dk_nrf52840 (read/write) 838331 838283 -48 -0.0
bss 110324 110324 0 0.0
rodata 93180 93180 0 0.0
text 559388 559336 -52 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 763626 763562 -64 -0.0
bss 111732 111732 0 0.0
rodata 88484 88484 0 0.0
text 488940 488884 -56 -0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497323 497323 0 0.0
bss 51824 51824 0 0.0
rodata 45776 45776 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 844439 844391 -48 -0.0
bss 110460 110460 0 0.0
rodata 94888 94888 0 0.0
text 563568 563516 -52 -0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 838183 838135 -48 -0.0
bss 110360 110360 0 0.0
rodata 93176 93176 0 0.0
text 559124 559072 -52 -0.0
shell nrf52840dk_nrf52840 (read/write) 775975 775975 0 0.0
bss 109080 109080 0 0.0
rodata 72412 72412 0 0.0
text 519904 519904 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 691010 691010 0 0.0
bss 110060 110060 0 0.0
rodata 67052 67052 0 0.0
text 440496 440496 0 0.0
p6 all-clusters-app default (read/write) 2301080 2300056 -1024 -0.0
.bss 107880 107880 0 0.0
.data 2520 2520 0 0.0
.heap 922944 922944 0 0.0
.text 1259344 1258320 -1024 -0.1
lock-app default (read/write) 2213928 2212912 -1016 -0.0
.bss 95680 95680 0 0.0
.data 2392 2392 0 0.0
.heap 935272 935272 0 0.0
.text 1172192 1171176 -1016 -0.1
qpg lighting-app qpg6100+debug (read only) 490932 490892 -40 -0.0
(read/write) 114140 114140 0 0.0
.bss 50968 50968 0 0.0
.data 1004 1004 0 0.0
.text 485612 485572 -40 -0.0
lock-app qpg6100+debug (read only) 467280 467224 -56 -0.0
(read/write) 114144 114144 0 0.0
.bss 49912 49912 0 0.0
.data 960 960 0 0.0
.text 461960 461904 -56 -0.0
persistent-storage-app qpg6100+debug (read only) 153212 153212 0 0.0
(read/write) 114140 114140 0 0.0
.bss 18920 18920 0 0.0
.data 356 356 0 0.0
.text 147892 147892 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 663086 663006 -80 -0.0
bss 69100 69100 0 0.0
noinit 33216 33216 0 0.0
text 458206 458130 -76 -0.0

@andy31415
Copy link
Contributor

fast track: PR opened for 1 week, developed by a domain owner and reviewed&approved by another domain owner

@andy31415 andy31415 merged commit f5ec35d into project-chip:master Nov 4, 2021
This was referenced Nov 4, 2021
Closed
Closed
Closed
Closed
@erjiaqing erjiaqing mentioned this pull request Nov 5, 2021
Merged
PSONALl pushed a commit to PSONALl/connectedhomeip that referenced this pull request Dec 3, 2021
@erjiaqing
[im] Fix wildcard path support per spec (project-chip#11115)
0c227e0 
* [im] Fix wildcard path support per spec

* Fix

* Move kInvalid* to private
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@andy31415 andy31415 andy31415 approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@pan-apple pan-apple Awaiting requested review from pan-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

Assignees
No one assigned
Labels
app controller fast track review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@erjiaqing @andy31415 @mrjerryjohns @bzbarsky-apple