Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Linux]:Enable additional dbus APIs for BSS management #11067

Merged
merged 1 commit into from
Oct 27, 2021
Merged

[Linux]:Enable additional dbus APIs for BSS management #11067

merged 1 commit into from
Oct 27, 2021

Conversation

yufengwangca
Copy link
Contributor

@yufengwangca yufengwangca commented Oct 27, 2021 •
edited
Loading

Problem

What is being fixed? Examples:

  • We are missing the dbus APIs for BSS management in Linux reference implementation. Those APIs are needed for diagnostic analysis in AP mode.

Change overview

Enable additional dbus APIs for BSS management

Testing

How was this tested? (at least one bullet point required)

  • Confirm chip sdk can connect to wpa_supplicant bss proxy successfully via DBUS.
    [1635313608.287005][1753388:1753388] CHIP:SVR: Manual pairing code: [34970112332]
    [1635313608.287014][1753388:1753388] CHIP:DL: wpa_supplicant: Start WiFi management
    [1635313608.288823][1753388:1753391] CHIP:DL: wpa_supplicant: connected to wpa_supplicant proxy
    [1635313608.289341][1753388:1753391] CHIP:DL: wpa_supplicant: WiFi interface: /fi/w1/wpa_supplicant1/Interfaces/15
    [1635313608.292600][1753388:1753391] CHIP:DL: wpa_supplicant: connected to wpa_supplicant interface proxy
    [1635313608.292934][1753388:1753391] CHIP:DL: wpa_supplicant: connected to wpa_supplicant bss proxy

@github-actions
Copy link

github-actions bot commented Oct 27, 2021 •
edited
Loading

PR #11067: Size comparison from 837bd28 to 0290fa5

Increases above 0.2%:

platform target config section 837bd28 0290fa5 change % change
linux all-clusters-app debug (read only) 1635553 1641945 6392 0.4
(read/write) 117472 117888 416 0.4
.data.rel.ro 60928 61312 384 0.6
.rodata 135477 136533 1056 0.8
.text 1368338 1373218 4880 0.4
lighting-app debug+rpc (read only) 1528521 1534913 6392 0.4
(read/write) 101520 101936 416 0.4
.data.rel.ro 53968 54352 384 0.7
.rodata 127793 128849 1056 0.8
.text 1268706 1273586 4880 0.4
shell debug (read only) 779929 786337 6408 0.8
(read/write) 57376 57792 416 0.7
.data.rel.ro 36496 36880 384 1.1
.rodata 76463 77519 1056 1.4
.text 602338 607234 4896 0.8
tv-app debug (read only) 1756009 1762401 6392 0.4
.data.rel.ro 58192 58576 384 0.7
.rodata 152888 153944 1056 0.7
.text 1461410 1466290 4880 0.3
Increases (8 builds for linux)
platform target config section 837bd28 0290fa5 change % change
linux all-clusters-app debug (read only) 1635553 1641945 6392 0.4
(read/write) 117472 117888 416 0.4
.bss 50320 50352 32 0.1
.data.rel.ro 60928 61312 384 0.6
.rodata 135477 136533 1056 0.8
.text 1368338 1373218 4880 0.4
bridge-app debug+rpc (read only) 1276829 1276957 128 0.0
.rodata 110620 110748 128 0.1
chip-tool debug (read only) 4178413 4178541 128 0.0
.rodata 212496 212624 128 0.1
lighting-app debug+rpc (read only) 1528521 1534913 6392 0.4
(read/write) 101520 101936 416 0.4
.bss 41176 41208 32 0.1
.data.rel.ro 53968 54352 384 0.7
.rodata 127793 128849 1056 0.8
.text 1268706 1273586 4880 0.4
ota-provider-app debug (read only) 1236097 1236225 128 0.0
.rodata 110920 111048 128 0.1
ota-requestor-app debug (read only) 1298449 1298577 128 0.0
.rodata 127744 127872 128 0.1
shell debug (read only) 779929 786337 6408 0.8
(read/write) 57376 57792 416 0.7
.bss 16136 16168 32 0.2
.data.rel.ro 36496 36880 384 1.1
.rodata 76463 77519 1056 1.4
.text 602338 607234 4896 0.8
tv-app debug (read only) 1756009 1762401 6392 0.4
(read/write) 289112 289528 416 0.1
.bss 223248 223280 32 0.0
.data.rel.ro 58192 58576 384 0.7
.rodata 152888 153944 1056 0.7
.text 1461410 1466290 4880 0.3
Full report (36 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 837bd28 0290fa5 change % change
efr32 lighting-app BRD4161A (read only) 737080 737080 0 0.0
(read/write) 115444 115444 0 0.0
.bss 113692 113692 0 0.0
.data 1752 1752 0 0.0
.text 737072 737072 0 0.0
BRD4161A+rpc (read only) 724508 724508 0 0.0
(read/write) 132048 132048 0 0.0
.bss 130196 130196 0 0.0
.data 1852 1852 0 0.0
.text 724500 724500 0 0.0
lock-app BRD4161A (read only) 716344 716344 0 0.0
(read/write) 113260 113260 0 0.0
.bss 111548 111548 0 0.0
.data 1712 1712 0 0.0
.text 716336 716336 0 0.0
window-app BRD4161A (read only) 717264 717264 0 0.0
(read/write) 113588 113588 0 0.0
.bss 111868 111868 0 0.0
.data 1716 1716 0 0.0
.text 717256 717256 0 0.0
esp32 all-clusters-app c3devkit (read only) 875950 875950 0 0.0
(read/write) 1306520 1306520 0 0.0
.dram0.bss 58248 58248 0 0.0
.dram0.data 16464 16464 0 0.0
.flash.rodata 198568 198568 0 0.0
.flash.text 875950 875950 0 0.0
.iram0.text 57564 57564 0 0.0
m5stack (read only) 907123 907123 0 0.0
(read/write) 426312 426312 0 0.0
.dram0.bss 60752 60752 0 0.0
.dram0.data 32084 32084 0 0.0
.flash.rodata 207312 207312 0 0.0
.flash.text 907123 907123 0 0.0
.iram0.text 125115 125115 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 701048 701048 0 0.0
.bss 78720 78720 0 0.0
.data 1900 1900 0 0.0
.text 614628 614628 0 0.0
lock-app k32w061+debug (read/write) 592964 592964 0 0.0
.bss 69196 69196 0 0.0
.data 1864 1864 0 0.0
.text 516104 516104 0 0.0
shell k32w061+debug (read/write) 425252 425252 0 0.0
.bss 63256 63256 0 0.0
.data 672 672 0 0.0
.text 359620 359620 0 0.0
linux all-clusters-app debug (read only) 1635553 1641945 6392 0.4
(read/write) 117472 117888 416 0.4
.bss 50320 50352 32 0.1
.data 978 978 0 0.0
.data.rel.ro 60928 61312 384 0.6
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 520 520 0 0.0
.rodata 135477 136533 1056 0.8
.text 1368338 1373218 4880 0.4
bridge-app debug+rpc (read only) 1276829 1276957 128 0.0
(read/write) 85096 85096 0 0.0
.bss 51856 51856 0 0.0
.data 976 976 0 0.0
.data.rel.ro 27272 27272 0 0.0
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 400 400 0 0.0
.rodata 110620 110748 128 0.1
.text 1070869 1070869 0 0.0
chip-tool debug (read only) 4178413 4178541 128 0.0
(read/write) 120896 120896 0 0.0
.bss 17680 17680 0 0.0
.data 1584 1584 0 0.0
.data.rel.ro 96208 96208 0 0.0
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 424 424 0 0.0
.rodata 212496 212624 128 0.1
.text 3706021 3706021 0 0.0
lighting-app debug+rpc (read only) 1528521 1534913 6392 0.4
(read/write) 101520 101936 416 0.4
.bss 41176 41208 32 0.1
.data 1106 1106 0 0.0
.data.rel.ro 53968 54352 384 0.7
.dynamic 608 608 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 528 528 0 0.0
.rodata 127793 128849 1056 0.8
.text 1268706 1273586 4880 0.4
ota-provider-app debug (read only) 1236097 1236225 128 0.0
(read/write) 67776 67776 0 0.0
.bss 37440 37440 0 0.0
.data 752 752 0 0.0
.data.rel.ro 24488 24488 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 440 440 0 0.0
.rodata 110920 111048 128 0.1
.text 1029218 1029218 0 0.0
ota-requestor-app debug (read only) 1298449 1298577 128 0.0
(read/write) 76520 76520 0 0.0
.bss 45216 45216 0 0.0
.data 816 816 0 0.0
.data.rel.ro 25352 25352 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 512 512 0 0.0
.rodata 127744 127872 128 0.1
.text 1073106 1073106 0 0.0
shell debug (read only) 779929 786337 6408 0.8
(read/write) 57376 57792 416 0.7
.bss 16136 16168 32 0.2
.data 242 242 0 0.0
.data.rel.ro 36496 36880 384 1.1
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 336 336 0 0.0
.rodata 76463 77519 1056 1.4
.text 602338 607234 4896 0.8
tv-app debug (read only) 1756009 1762401 6392 0.4
(read/write) 289112 289528 416 0.1
.bss 223248 223280 32 0.0
.data 2032 2032 0 0.0
.data.rel.ro 58192 58576 384 0.7
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 608 608 0 0.0
.rodata 152888 153944 1056 0.7
.text 1461410 1466290 4880 0.3
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2288776 2288776 0 0.0
.bss 179612 179612 0 0.0
.data 5192 5192 0 0.0
.heap 851640 851640 0 0.0
.text 1251376 1251376 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2255960 2255960 0 0.0
.bss 171060 171060 0 0.0
.data 5464 5464 0 0.0
.heap 859920 859920 0 0.0
.text 1218560 1218560 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2233992 2233992 0 0.0
.bss 169988 169988 0 0.0
.data 5432 5432 0 0.0
.heap 861024 861024 0 0.0
.text 1196592 1196592 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139680 1139680 0 0.0
.bss 11760 11760 0 0.0
.data 4360 4360 0 0.0
.heap 1020328 1020328 0 0.0
.text 103064 103064 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 862903 862903 0 0.0
bss 112136 112136 0 0.0
rodata 97504 97504 0 0.0
text 577632 577632 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 823743 823743 0 0.0
bss 108380 108380 0 0.0
rodata 88280 88280 0 0.0
text 550824 550824 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 787926 787926 0 0.0
bss 113512 113512 0 0.0
rodata 92744 92744 0 0.0
text 507104 507104 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 839847 839847 0 0.0
bss 111208 111208 0 0.0
rodata 93904 93904 0 0.0
text 559192 559192 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 764874 764874 0 0.0
bss 112584 112584 0 0.0
rodata 89164 89164 0 0.0
text 488656 488656 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497339 497339 0 0.0
bss 51824 51824 0 0.0
rodata 45776 45776 0 0.0
text 339456 339456 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 844247 844247 0 0.0
bss 111308 111308 0 0.0
rodata 95104 95104 0 0.0
text 562296 562296 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 839567 839567 0 0.0
bss 111208 111208 0 0.0
rodata 93880 93880 0 0.0
text 558936 558936 0 0.0
shell nrf52840dk_nrf52840 (read/write) 776435 776435 0 0.0
bss 109072 109072 0 0.0
rodata 72536 72536 0 0.0
text 520232 520232 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 691490 691490 0 0.0
bss 110056 110056 0 0.0
rodata 67180 67180 0 0.0
text 440844 440844 0 0.0
p6 lock-app default (read/write) 2169160 2169160 0 0.0
.bss 67184 67184 0 0.0
.data 2416 2416 0 0.0
.heap 963744 963744 0 0.0
.text 1127424 1127424 0 0.0
qpg lighting-app qpg6100+debug (read only) 491224 491224 0 0.0
(read/write) 114144 114144 0 0.0
.bss 52416 52416 0 0.0
.data 1000 1000 0 0.0
.text 485904 485904 0 0.0
lock-app qpg6100+debug (read only) 467548 467548 0 0.0
(read/write) 114140 114140 0 0.0
.bss 51368 51368 0 0.0
.data 956 956 0 0.0
.text 462228 462228 0 0.0
persistent-storage-app qpg6100+debug (read only) 155244 155244 0 0.0
(read/write) 114140 114140 0 0.0
.bss 27752 27752 0 0.0
.data 372 372 0 0.0
.text 149924 149924 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 664606 664606 0 0.0
bss 69944 69944 0 0.0
noinit 33216 33216 0 0.0
text 458202 458202 0 0.0

@yufengwangca yufengwangca merged commit 676a10e into project-chip:master Oct 27, 2021
JasonLiuZhuoCheng pushed a commit to JasonLiuZhuoCheng/connectedhomeip that referenced this pull request Oct 28, 2021
@yufengwangca @JasonLiuZhuoCheng
[linux]:Enable extra dbus APIs for BSS management (project-chip#11067)
eaa1946
@yufengwangca yufengwangca deleted the pr/linux/bss branch October 28, 2021 17:20
carol-apple pushed a commit to carol-apple/connectedhomeip that referenced this pull request Oct 28, 2021
@yufengwangca @carol-apple
[linux]:Enable extra dbus APIs for BSS management (project-chip#11067)
09234bf
PSONALl pushed a commit to PSONALl/connectedhomeip that referenced this pull request Dec 3, 2021
@yufengwangca
[linux]:Enable extra dbus APIs for BSS management (project-chip#11067)
00afbdd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woody-apple woody-apple woody-apple approved these changes

@yunhanw-google yunhanw-google yunhanw-google approved these changes

@msandstedt msandstedt msandstedt approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mspang mspang Awaiting requested review from mspang

@pan-apple pan-apple Awaiting requested review from pan-apple

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

Assignees
No one assigned
Labels
linux platform review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yufengwangca @msandstedt @yunhanw-google @woody-apple