-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add logs to debug Darwin CI failures #11005
Merged
woody-apple
merged 2 commits into
project-chip:master
from
pan-apple:debug-darwin-tests
Oct 28, 2021
Merged
Add logs to debug Darwin CI failures #11005
woody-apple
merged 2 commits into
project-chip:master
from
pan-apple:debug-darwin-tests
Oct 28, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #11005: Size comparison from 7b14930 to 24385f5 Increases (29 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (36 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
Size increase report for "gn_qpg-example-build" from 7b14930
Full report output
|
Size increase report for "nrfconnect-example-build" from 7b14930
Full report output
|
Size increase report for "esp32-example-build" from 7b14930
Full report output
|
pan-apple
force-pushed
the
debug-darwin-tests
branch
from
October 28, 2021 17:51
24385f5
to
48efc98
Compare
pan-apple
changed the title
[Do not review/merge] Debug failures in Darwin CI
Add logs to debug Darwin CI failures
Oct 28, 2021
pullapprove
bot
requested review from
anush-apple,
austinh0,
balducci-apple,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chulspro,
Damian-Nordic,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
harimau-qirex,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs and
kghost
October 28, 2021 17:56
pullapprove
bot
requested review from
kpschoedel,
LuDuda,
msandstedt,
sagar-apple,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
vivien-apple,
wbschiller,
woody-apple,
yufengwangca and
yunhanw-google
October 28, 2021 17:56
pan-apple
force-pushed
the
debug-darwin-tests
branch
from
October 28, 2021 18:00
48efc98
to
540a164
Compare
PR #11005: Size comparison from 52db0e4 to 540a164 Increases above 0.2%:
Increases (28 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Full report (37 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
woody-apple
approved these changes
Oct 28, 2021
Fast tracking, given this adds logs to debug CI failures |
PSONALl
pushed a commit
to PSONALl/connectedhomeip
that referenced
this pull request
Dec 3, 2021
* Debug failures in Darwin CI * Formalize PR by adding ChipLogByteSpan
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Darwin CI is occasionally failing during CASE sessions setup.
Change overview
The logs point at the mismatch of fabric information between the controller and the device. On receiving Sigma1, the device computes destination ID from the commissioned fabrics and matches it against the received value in Sigma1 message. This check is failing. Also, noticed that the compressed fabric ID generated on the device is different than the controller.
This PR adds logs to narrow down the failure cause. It'll log the buffer that's input to computation of compressed fabric ID and the destination ID.
Testing
This PR adds some logs and makes no other functional change. It was tested for compilation and correct logging using chip-tool and all-cluster-app.