Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Trivial] emberAfIsTypeSigned doesn't return true for all signed types #35147

Closed
hasty opened this issue Aug 22, 2024 · 1 comment · Fixed by #35412
Closed

[Trivial] emberAfIsTypeSigned doesn't return true for all signed types #35147

hasty opened this issue Aug 22, 2024 · 1 comment · Fixed by #35412
Labels
bug Something isn't working needs triage

Comments

@hasty
Copy link
Contributor

hasty commented Aug 22, 2024

Type

Other

Explanation

Namely, ZCL_POWER_MW_ATTRIBUTE_TYPE, ZCL_AMPERAGE_MA_ATTRIBUTE_TYPE, ZCL_VOLTAGE_MV_ATTRIBUTE_TYPE, ZCL_ENERGY_MWH_ATTRIBUTE_TYPE

Platform

all

Platform Version(s)

No response

Testing

Manually tested with SDK

(Optional) If manually tested please explain why this is only manually tested

No response

Anything else?

No response
@hasty hasty added bug Something isn't working needs triage labels Aug 22, 2024
@bzbarsky-apple
Copy link
Contributor

Note that this will become IsSignedIntegerAttribute in #32632

bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Sep 4, 2024
@bzbarsky-apple
Stop hardcoding the list of signed integer attribute types.
b157fa5 
ZAP has this information.  We should just use that instead of duplicating it.

Fixes project-chip#35147
@bzbarsky-apple bzbarsky-apple mentioned this issue Sep 4, 2024
Merged
@mergify mergify bot closed this as completed in #35412 Sep 4, 2024
@mergify mergify bot closed this as completed in e18f910 Sep 4, 2024
shgutte pushed a commit to shgutte/connectedhomeip that referenced this issue Sep 10, 2024
@bzbarsky-apple @shgutte
Stop hardcoding the list of signed integer attribute types. (project-…
34cd75f 
…chip#35412)

ZAP has this information.  We should just use that instead of duplicating it.

Fixes project-chip#35147
ArekBalysNordic pushed a commit to ArekBalysNordic/sdk-connectedhomeip that referenced this issue Nov 28, 2024
@bzbarsky-apple @ArekBalysNordic
Stop hardcoding the list of signed integer attribute types. (#35412)
66dd7f8 
ZAP has this information.  We should just use that instead of duplicating it.

Fixes project-chip/connectedhomeip#35147
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working needs triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Stop hardcoding the list of signed integer attribute types. bzbarsky-apple/connectedhomeip
2 participants
@hasty @bzbarsky-apple