Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Configuration for MATTTER_TRACING_ENABLED looks broken #29214

Closed
bzbarsky-apple opened this issue Sep 13, 2023 · 0 comments · Fixed by #29219
Closed

[BUG] Configuration for MATTTER_TRACING_ENABLED looks broken #29214

bzbarsky-apple opened this issue Sep 13, 2023 · 0 comments · Fixed by #29219
Labels
bug Something isn't working linux needs triage

Comments

@bzbarsky-apple
Copy link
Contributor

Reproduction steps

When compiling with -Wundef, I get this error:

In file included from ../../../examples/all-clusters-app/linux/third_party/connectedhomeip/examples/common/tracing/TracingCommandLineArgument.cpp:23:
../../../examples/all-clusters-app/linux/third_party/connectedhomeip/src/tracing/registry.h:70:5: error: 'MATTER_TRACING_ENABLED' is not defined, evaluates to 0 [-Werror,-Wundef]
#if MATTER_TRACING_ENABLED

Looks like the gn things we are doing to define that macro are not getting picked up properly by things that are including registry.h....

Bug prevalence

Always

GitHub hash of the SDK that was being used

b02c984

Platform

core

Platform Version(s)

No response

Anything else?

No response
@bzbarsky-apple bzbarsky-apple added bug Something isn't working needs triage labels Sep 13, 2023
@github-actions github-actions bot added the linux label Sep 13, 2023
@bzbarsky-apple bzbarsky-apple mentioned this issue Sep 13, 2023
Open
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Sep 13, 2023
@bzbarsky-apple
Fix MATTER_TRACING_ENABLED checks.
569cb2a 
We were checking MATTTER_TRACING_ENABLED without including the config header
that defines it.

Fixes project-chip#29214
@bzbarsky-apple bzbarsky-apple mentioned this issue Sep 13, 2023
Merged
@mergify mergify bot closed this as completed in #29219 Sep 13, 2023
mergify bot pushed a commit that referenced this issue Sep 13, 2023
@bzbarsky-apple
Fix MATTER_TRACING_ENABLED checks. (#29219)
b06c94f 
We were checking MATTTER_TRACING_ENABLED without including the config header
that defines it.

Fixes #29214
HunsupJung pushed a commit to HunsupJung/connectedhomeip that referenced this issue Oct 23, 2023
@bzbarsky-apple @HunsupJung
Fix MATTER_TRACING_ENABLED checks. (project-chip#29219)
a5c56b7 
We were checking MATTTER_TRACING_ENABLED without including the config header
that defines it.

Fixes project-chip#29214
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working linux needs triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix MATTER_TRACING_ENABLED checks. bzbarsky-apple/connectedhomeip
1 participant
@bzbarsky-apple