Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Make SessionResumptionStorage injectable in controller #28351

Closed
bzbarsky-apple opened this issue Jul 28, 2023 · 0 comments · Fixed by #28422
Closed

[Feature] Make SessionResumptionStorage injectable in controller #28351

bzbarsky-apple opened this issue Jul 28, 2023 · 0 comments · Fixed by #28422
Labels
feature request feature work needs triage

Comments

@bzbarsky-apple
Copy link
Contributor

Feature description

SessionResumptionStorage is currently not injectable into the controller factory. When we create a SystemState, we just always create a SimpleSessionResumptionStorage.

We should make it possible to inject an SDK-consumer-provided storage implementation here.

Platform

core

Platform Version(s)

No response

Anything else?

No response
@bzbarsky-apple bzbarsky-apple changed the title [Feature] Make SesssionResumptionStorage injectable in controller [Feature] Make SessionResumptionStorage injectable in controller Jul 31, 2023
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Jul 31, 2023
@bzbarsky-apple
Make SessionResumptionStorage injectable in controller.
a68a29e 
Fixes project-chip#28351
@bzbarsky-apple bzbarsky-apple mentioned this issue Jul 31, 2023
Merged
@mergify mergify bot closed this as completed in #28422 Aug 1, 2023
mergify bot pushed a commit that referenced this issue Aug 1, 2023
@bzbarsky-apple
Make SessionResumptionStorage injectable in controller. (#28422)
83595bb 
* Make SessionResumptionStorage injectable in controller.

Fixes #28351

* Address review comment.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request feature work needs triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make SessionResumptionStorage injectable in controller. bzbarsky-apple/connectedhomeip
1 participant
@bzbarsky-apple