Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the enum values for EndOfServiceEnum #27563

Closed
robszewczyk opened this issue Jun 30, 2023 · 0 comments · Fixed by #27564
Closed

Change the enum values for EndOfServiceEnum #27563

robszewczyk opened this issue Jun 30, 2023 · 0 comments · Fixed by #27564
Labels
cluster xml for 1.2 Spec XML align SDK XML does not match the spec (including naming, etc) v1.2

Comments

@robszewczyk
Copy link
Contributor

The enum values departed from the common pattern of 0 being the normal / nominal value. The enum values should be

  • 0 -- Normal
  • 1 -- Expired
@robszewczyk robszewczyk added v1.2 Spec XML align SDK XML does not match the spec (including naming, etc) cluster xml for 1.2 labels Jun 30, 2023
robszewczyk added a commit that referenced this issue Jun 30, 2023
@robszewczyk
Reorder EndOfServiceEnum elements according to the canonical pattern
e19a9d4 
Fixes #27563
@robszewczyk robszewczyk mentioned this issue Jun 30, 2023
Merged
robszewczyk added a commit that referenced this issue Jun 30, 2023
@robszewczyk
Reorder EndOfServiceEnum elements according to the canonical pattern (#…
9c7cab8 
…27564)

* Reorder EndOfServiceEnum elements according to the canonical pattern

Fixes #27563

* Regenerated dependent files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cluster xml for 1.2 Spec XML align SDK XML does not match the spec (including naming, etc) v1.2
Projects
[Enhancements] Spec/XML Alignment
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reorder EndOfServiceEnum elements according to the canonical pattern project-chip/connectedhomeip
1 participant
@robszewczyk