Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Matter framework API for converting data-value dictionaries into strongly typed structs #26305

Closed
bzbarsky-apple opened this issue Apr 28, 2023 · 2 comments · Fixed by #26321
Closed

Add Matter framework API for converting data-value dictionaries into strongly typed structs #26305

bzbarsky-apple opened this issue Apr 28, 2023 · 2 comments · Fixed by #26321
Assignees
@bzbarsky-apple

Comments

@bzbarsky-apple
Copy link
Contributor

The idea would be to allow consumers to try using the Matter framework to convert to a strongly typed thing, and then if we don't have the schema for it fall back on their own processing.
@bzbarsky-apple bzbarsky-apple self-assigned this Apr 28, 2023
@bzbarsky-apple
Copy link
Contributor Author

bzbarsky-apple commented Apr 28, 2023 •
edited
Loading

Implementation plan, courtesy of @jtung-apple:

  1. Use MTREncodeTLVFromDataValueDictionary to convert the dictionary to TLV.
  2. Use our existing "parse it from TLV" code for attributes and events.

@bzbarsky-apple
Copy link
Contributor Author

And for command payloads, need to think a bit about what we do.

bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue May 1, 2023
@bzbarsky-apple
Add methods for doing schema-checks on response-value dictionaries.
96a9fbd 
This adds a way to initialize an MTRAttributeReport or MTREventReport from a
response-value dictionary, if we have known schema for the attribute/event path.

Fixes project-chip#26305
@bzbarsky-apple bzbarsky-apple mentioned this issue May 1, 2023
Merged
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue May 2, 2023
@bzbarsky-apple
Add methods for doing schema-checks on response-value dictionaries.
1dca249 
This adds a way to initialize an MTRAttributeReport or MTREventReport from a
response-value dictionary, if we have known schema for the attribute/event path.

Fixes project-chip#26305
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue May 3, 2023
@bzbarsky-apple
Add methods for doing schema-checks on response-value dictionaries.
358f01a 
This adds a way to initialize an MTRAttributeReport or MTREventReport from a
response-value dictionary, if we have known schema for the attribute/event path.

Fixes project-chip#26305
bzbarsky-apple added a commit that referenced this issue May 9, 2023
@bzbarsky-apple
Add methods for doing schema-checks on response-value dictionaries. (#…
51092c9 
…26321)

* Add methods for doing schema-checks on response-value dictionaries.

This adds a way to initialize an MTRAttributeReport or MTREventReport from a
response-value dictionary, if we have known schema for the attribute/event path.

Fixes #26305

* Address review comment.

* Address review comment.

* Stop requiring a fixed-size up-front allocation for our attribute value.

* Improve comments.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bzbarsky-apple bzbarsky-apple

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add methods for doing schema-checks on response-value dictionaries. bzbarsky-apple/connectedhomeip
1 participant
@bzbarsky-apple