Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some cleanup around read/subscribeAttributePaths #26169

Closed
bzbarsky-apple opened this issue Apr 19, 2023 · 0 comments · Fixed by #26171
Closed

Some cleanup around read/subscribeAttributePaths #26169

bzbarsky-apple opened this issue Apr 19, 2023 · 0 comments · Fixed by #26171
Assignees
@bzbarsky-apple
Labels
darwin

Comments

@bzbarsky-apple
Copy link
Contributor

  1. When copying arrays, can just use [[NSArray alloc] initWithArray:existingArray copyItems:YES] instead of doing it by hand.
  2. Erroring out on empty paths for subscribe makes sense, but for read should just respond with empty array. That would match the behavior of actually sending the corresponding requests to the server.
@bzbarsky-apple bzbarsky-apple self-assigned this Apr 19, 2023
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Apr 20, 2023
@bzbarsky-apple
Minor cleanup around read/subscribe(To)AttributePaths.
379982b 
1) Use initWithArray:copyItems:YES when copying arrays, instead of hand-rolling
   the copy.
2) For read, empty paths should just lead to an empty result, not an error, just
   like they would if the read actually happened.

Fixes project-chip#26169
@bzbarsky-apple bzbarsky-apple mentioned this issue Apr 20, 2023
Merged
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Apr 20, 2023
@bzbarsky-apple
Minor cleanup around read/subscribe(To)AttributePaths.
5c8a191 
1) Use initWithArray:copyItems:YES when copying arrays, instead of hand-rolling
   the copy.
2) For read, empty paths should just lead to an empty result, not an error, just
   like they would if the read actually happened.

Fixes project-chip#26169
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Apr 24, 2023
@bzbarsky-apple
Minor cleanup around read/subscribe(To)AttributePaths.
bc30268 
1) Use initWithArray:copyItems:YES when copying arrays, instead of hand-rolling
   the copy.
2) For read, empty paths should just lead to an empty result, not an error, just
   like they would if the read actually happened.

Fixes project-chip#26169
bzbarsky-apple added a commit that referenced this issue Apr 24, 2023
@bzbarsky-apple
Minor cleanup around read/subscribe(To)AttributePaths. (#26171)
b42d23a 
1) Use initWithArray:copyItems:YES when copying arrays, instead of hand-rolling
   the copy.
2) For read, empty paths should just lead to an empty result, not an error, just
   like they would if the read actually happened.

Fixes #26169
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bzbarsky-apple bzbarsky-apple

Labels
darwin
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Minor cleanup around read/subscribe(To)AttributePaths. bzbarsky-apple/connectedhomeip
1 participant
@bzbarsky-apple