Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SVE2] Diagnostics Data Provider - incorrect kMaxThreadNameLength #22336

Closed
doru91 opened this issue Sep 1, 2022 · 0 comments · Fixed by #22337
Closed

[SVE2] Diagnostics Data Provider - incorrect kMaxThreadNameLength #22336

doru91 opened this issue Sep 1, 2022 · 0 comments · Fixed by #22337

Comments

@doru91
Copy link
Contributor

doru91 commented Sep 1, 2022

Problem

kMaxThreadNameLength currently set to 32. Spec mandates it to 8

Proposed Solution

Fix https://github.com/project-chip/connectedhomeip/blob/sve-2/src/include/platform/DiagnosticDataProvider.h#L36
@doru91 doru91 changed the title Diagnostics Data Provider - incorrect kMaxThreadNameLength [SVE2] Diagnostics Data Provider - incorrect kMaxThreadNameLength Sep 1, 2022
doru91 added a commit to NXP/matter that referenced this issue Sep 1, 2022
@doru91
[SVE2] Fix kMaxThreadNameLength
c685a3c 
Fix project-chip#22336

Signed-off-by: Doru Gucea <[email protected]>
@doru91 doru91 mentioned this issue Sep 1, 2022
Merged
andy31415 pushed a commit that referenced this issue Sep 2, 2022
@doru91
[SVE2] Fix kMaxThreadNameLength (#22337)
2752626 
Fix #22336

Signed-off-by: Doru Gucea <[email protected]>

Signed-off-by: Doru Gucea <[email protected]>
@woody-apple woody-apple mentioned this issue Sep 2, 2022
Merged
github-actions bot pushed a commit that referenced this issue Sep 2, 2022
@doru91 @web-flow
[SVE2] Fix kMaxThreadNameLength (#22337)
227889b 
Fix #22336

Signed-off-by: Doru Gucea <[email protected]>

Signed-off-by: Doru Gucea <[email protected]>
doru91 added a commit to NXP/matter that referenced this issue Sep 2, 2022
@doru91
[SVE2] Fix kMaxThreadNameLength (project-chip#22337)
a562b07 
Fix project-chip#22336

Signed-off-by: Doru Gucea <[email protected]>

Signed-off-by: Doru Gucea <[email protected]>
andy31415 added a commit that referenced this issue Sep 12, 2022
@woody-apple @emargolis
@doru91 @andy31415
[SVE2] Fix kMaxThreadNameLength (#22367)
4128509 
* chip-cert: Updated Tool to Support Comand Line Key/Cert Inputs. (#22142)

Other text updates.

* [SVE2] Fix kMaxThreadNameLength (#22337)

Fix #22336

Signed-off-by: Doru Gucea <[email protected]>

Signed-off-by: Doru Gucea <[email protected]>

* Revert "chip-cert: Updated Tool to Support Comand Line Key/Cert Inputs. (#22142)"

This reverts commit 0962e0b.

Signed-off-by: Doru Gucea <[email protected]>
Co-authored-by: Evgeny Margolis <[email protected]>
Co-authored-by: doru91 <[email protected]>
Co-authored-by: Andrei Litvin <[email protected]>
isiu-apple pushed a commit to isiu-apple/connectedhomeip that referenced this issue Sep 16, 2022
@doru91 @isiu-apple
[SVE2] Fix kMaxThreadNameLength (project-chip#22337)
9c66747 
Fix project-chip#22336

Signed-off-by: Doru Gucea <[email protected]>

Signed-off-by: Doru Gucea <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[SVE2] Fix kMaxThreadNameLength NXP/matter
1 participant
@doru91