Skip to content

Commit

Permalink
[controller] Fix CommissioningStage enum order for T&C acknowledgements
Browse files Browse the repository at this point in the history
Move kConfigureTCAcknowledgments before kCleanup in the CommissioningStage
enum to fix cirque test failures. The tests validate that commissioning stages
do not exceed kCleanup, which was causing failures when T&C acknowledgements
were positioned after it.

While the original comment from 2 years ago suggested the enum order was
fixed, testing reveals that the stages can be reordered. The cirque tests
now pass with this corrected ordering, indicating that any previous
constraints on enum ordering no longer apply.
  • Loading branch information
swan-amazon committed Dec 19, 2024
1 parent 3a55f1f commit ff8ab5f
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion src/controller/CommissioningDelegate.h
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,6 @@ enum CommissioningStage : uint8_t
kICDSendStayActive, ///< Send Keep Alive to ICD
/// Send ScanNetworks (0x31:0) command to the device.
/// ScanNetworks can happen anytime after kArmFailsafe.
/// However, the cirque tests fail if it is earlier in the list
kScanNetworks,
/// Waiting for the higher layer to provide network credentials before continuing the workflow.
/// Call CHIPDeviceController::NetworkCredentialsReady() when CommissioningParameters is populated with
Expand Down

0 comments on commit ff8ab5f

Please sign in to comment.