Enable asan for unit tests on Darwin when compiling with clang. (#11824)

bzbarsky-apple · pull[bot] · commit ec72e65721a3 · 2022-01-13T15:40:31.000Z
This immediately caught two bugs in things that were being unit-tested.

The Linux version fails to link for some reason, hence this is
Darwin-only.
diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml
@@ -301,7 +301,7 @@ jobs:
               run: |
                   for BUILD_TYPE  in clang python_lib; do
                       case $BUILD_TYPE in
-                          "clang") GN_ARGS='is_clang=true target_os="all"';;
+                          "clang") GN_ARGS='is_clang=true target_os="all" is_asan=true';;
                           "python_lib") GN_ARGS='enable_rtti=true enable_pylib=true';;
                       esac
                       scripts/build/gn_gen.sh --args="$GN_ARGS"
diff --git a/src/access/tests/TestAccessControl.cpp b/src/access/tests/TestAccessControl.cpp
@@ -671,7 +671,7 @@ void TestDeleteEntry(nlTestSuite * inSuite, void * inContext)
             NL_TEST_ASSERT(inSuite, ClearAccessControl(accessControl) == CHIP_NO_ERROR);
             NL_TEST_ASSERT(inSuite, LoadAccessControl(accessControl, data, ArraySize(data)) == CHIP_NO_ERROR);
 
-            memcpy(&data[pos], &data[pos + count], (ArraySize(data) - count - pos) * sizeof(data[0]));
+            memmove(&data[pos], &data[pos + count], (ArraySize(data) - count - pos) * sizeof(data[0]));
 
             for (size_t i = 0; i < count; ++i)
             {
diff --git a/src/protocols/bdx/BdxMessages.cpp b/src/protocols/bdx/BdxMessages.cpp
@@ -170,7 +170,7 @@ size_t TransferInit::MessageSize() const
 void TransferInit::LogMessage(bdx::MessageType messageType) const
 {
     char fd[kMaxFileDesignatorLen];
-    snprintf(fd, sizeof(fd), "%s", FileDesignator);
+    snprintf(fd, sizeof(fd), "%.*s", static_cast<int>(FileDesLength), FileDesignator);
 
     switch (messageType)
     {
diff --git a/src/protocols/user_directed_commissioning/UserDirectedCommissioning.h b/src/protocols/user_directed_commissioning/UserDirectedCommissioning.h
@@ -183,7 +183,7 @@ class DLL_EXPORT UserDirectedCommissioningServer : public TransportMgrDelegate
      * Get the cache of UDC Clients
      *
      */
-    UDCClients<kMaxUDCClients> GetUDCClients() { return mUdcClients; }
+    UDCClients<kMaxUDCClients> & GetUDCClients() { return mUdcClients; }
 
     /**
      * Print the cache of UDC Clients

Original file line number	Diff line number	Diff line change
`@@ -671,7 +671,7 @@ void TestDeleteEntry(nlTestSuite * inSuite, void * inContext)`
`671`	`671`	`NL_TEST_ASSERT(inSuite, ClearAccessControl(accessControl) == CHIP_NO_ERROR);`
`672`	`672`	`NL_TEST_ASSERT(inSuite, LoadAccessControl(accessControl, data, ArraySize(data)) == CHIP_NO_ERROR);`
`673`	`673`
`674`		`- memcpy(&data[pos], &data[pos + count], (ArraySize(data) - count - pos) * sizeof(data[0]));`
	`674`	`+ memmove(&data[pos], &data[pos + count], (ArraySize(data) - count - pos) * sizeof(data[0]));`
`675`	`675`
`676`	`676`	`for (size_t i = 0; i < count; ++i)`
`677`	`677`	`{`
Original file line number	Diff line number	Diff line change
`@@ -170,7 +170,7 @@ size_t TransferInit::MessageSize() const`
`170`	`170`	`void TransferInit::LogMessage(bdx::MessageType messageType) const`
`171`	`171`	`{`
`172`	`172`	`char fd[kMaxFileDesignatorLen];`
`173`		`- snprintf(fd, sizeof(fd), "%s", FileDesignator);`
	`173`	`+ snprintf(fd, sizeof(fd), "%.*s", static_cast<int>(FileDesLength), FileDesignator);`
`174`	`174`
`175`	`175`	`switch (messageType)`
`176`	`176`	`{`
Original file line number	Diff line number	Diff line change
`@@ -183,7 +183,7 @@ class DLL_EXPORT UserDirectedCommissioningServer : public TransportMgrDelegate`
`183`	`183`	`* Get the cache of UDC Clients`
`184`	`184`	`*`
`185`	`185`	`*/`
`186`		`- UDCClients<kMaxUDCClients> GetUDCClients() { return mUdcClients; }`
	`186`	`+ UDCClients<kMaxUDCClients> & GetUDCClients() { return mUdcClients; }`
`187`	`187`
`188`	`188`	`/**`
`189`	`189`	`* Print the cache of UDC Clients`