Skip to content

Commit

Permalink
Address review comment - fix YAML to lock door before unlocking again…
Browse files Browse the repository at this point in the history
…. Restyle changes
  • Loading branch information
nivi-apple committed Mar 10, 2023
1 parent e8cd39e commit 4eda846
Show file tree
Hide file tree
Showing 3 changed files with 118 additions and 75 deletions.
3 changes: 2 additions & 1 deletion src/app/clusters/door-lock-server/door-lock-server.h
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,8 @@ class DoorLockServer
/**
* @brief Handles a wrong code entry attempt for the endpoint. If the number of wrong entry attempts exceeds the max limit,
* engage lockout. Otherwise increment the number of incorrect attempts by 1. This is handled automatically for
* remote operations - lock and unlock. Applications are responsible for calling it for non-remote incorrect credential presentation attempts.
* remote operations - lock and unlock. Applications are responsible for calling it for non-remote incorrect credential
* presentation attempts.
*
* @param endpointId
*/
Expand Down
14 changes: 14 additions & 0 deletions src/app/tests/suites/DL_LockUnlock.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -284,6 +284,20 @@ tests:
response:
value: 2

- label: "Lock the door back prior to next tests"
command: "LockDoor"
timedInteractionTimeoutMs: 10000
arguments:
values:
- name: "PINCode"
value: "123456"

- label: "Verify that lock state attribute value is set to Locked"
command: "readAttribute"
attribute: "LockState"
response:
value: 1

- label: "Try to unlock the door with invalid PIN for the first time"
command: "UnlockDoor"
timedInteractionTimeoutMs: 10000
Expand Down
Loading

0 comments on commit 4eda846

Please sign in to comment.