Skip to content

Commit

Permalink
Disable -Wdocumentation for libwebsocket. (#30341)
Browse files Browse the repository at this point in the history
It triggers tens of thousands of those warnings.

For the Xcode build of darwin-framework-tool, this just disables -Wdocumentation
across the board, since I don't see a way to do it for particular files.
  • Loading branch information
bzbarsky-apple authored Nov 9, 2023
1 parent 1b5a58a commit 42c3af2
Show file tree
Hide file tree
Showing 2 changed files with 20 additions and 2 deletions.
8 changes: 6 additions & 2 deletions examples/common/websocket-server/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,12 @@ import("//build_overrides/build.gni")
import("//build_overrides/chip.gni")

config("websocket_server_config_disable_warnings") {
# Unfortunately, some of the libwebsockets headers include -Wshadow failures.
cflags = [ "-Wno-shadow" ]
# Unfortunately, some of the libwebsockets headers include -Wshadow failures,
# and have tons of -Wdocumentation issues.
cflags = [
"-Wno-shadow",
"-Wno-documentation",
]
}

static_library("websocket-server") {
Expand Down
14 changes: 14 additions & 0 deletions src/darwin/Framework/Matter.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -1901,6 +1901,13 @@
SDKROOT = macosx;
STRIP_INSTALLED_PRODUCT = NO;
USER_HEADER_SEARCH_PATHS = "";
WARNING_CFLAGS = (
"-Wformat",
"-Wformat-nonliteral",
"-Wformat-security",
"-Wconversion",
"-Wno-documentation",
);
};
name = Debug;
};
Expand Down Expand Up @@ -1970,6 +1977,13 @@
PROVISIONING_PROFILE_SPECIFIER = "";
SDKROOT = macosx;
USER_HEADER_SEARCH_PATHS = "";
WARNING_CFLAGS = (
"-Wformat",
"-Wformat-nonliteral",
"-Wformat-security",
"-Wconversion",
"-Wno-documentation",
);
};
name = Release;
};
Expand Down

0 comments on commit 42c3af2

Please sign in to comment.