Skip to content

Commit

Permalink
Addressed comments by sharadb-amazon 2, fixed CP field name in Castin…
Browse files Browse the repository at this point in the history
…gStore
  • Loading branch information
pgregorr-amazon committed Apr 18, 2024
1 parent e5e3d83 commit 358046b
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ std::vector<core::CastingPlayer> CastingStore::ReadAll()
continue;
}

if (castingPlayerContainerTagNum == kCastingCommissionerPasscodeTag)
if (castingPlayerContainerTagNum == kCastingPlayerCommissionerPasscodeTag)
{
err = reader.Get(attributes.commissionerPasscode);
VerifyOrReturnValue(err == CHIP_NO_ERROR, std::vector<core::CastingPlayer>(),
Expand Down Expand Up @@ -481,7 +481,7 @@ CHIP_ERROR CastingStore::WriteAll(std::vector<core::CastingPlayer> castingPlayer
ReturnErrorOnFailure(tlvWriter.Put(chip::TLV::ContextTag(kCastingPlayerProductIdTag), castingPlayer.GetProductId()));
ReturnErrorOnFailure(tlvWriter.Put(chip::TLV::ContextTag(kCastingPlayerDeviceTypeIdTag), castingPlayer.GetDeviceType()));
ReturnErrorOnFailure(
tlvWriter.Put(chip::TLV::ContextTag(kCastingCommissionerPasscodeTag), castingPlayer.GetCommissionerPasscode()));
tlvWriter.Put(chip::TLV::ContextTag(kCastingPlayerCommissionerPasscodeTag), castingPlayer.GetCommissionerPasscode()));
ReturnErrorOnFailure(tlvWriter.Put(chip::TLV::ContextTag(kCastingPlayerPortTag), castingPlayer.GetPort()));
ReturnErrorOnFailure(tlvWriter.PutBytes(chip::TLV::ContextTag(kCastingPlayerInstanceNameTag),
(const uint8_t *) castingPlayer.GetInstanceName(),
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ class CastingStore : public chip::FabricTable::Delegate
kCastingPlayerPortTag,
kCastingPlayerInstanceNameTag,
kCastingPlayerDeviceNameTag,
kCastingCommissionerPasscodeTag,
kCastingPlayerCommissionerPasscodeTag,
kCastingPlayerHostNameTag,

kCastingPlayerEndpointsContainerTag,
Expand Down

0 comments on commit 358046b

Please sign in to comment.