Skip to content

Commit

Permalink
Remove unnecessary debug logs (#15470)
Browse files Browse the repository at this point in the history
* add darwin specific define for log

* Remove debug log
  • Loading branch information
mkardous-silabs authored and pull[bot] committed Nov 15, 2023
1 parent bd35020 commit 2220354
Showing 1 changed file with 2 additions and 6 deletions.
8 changes: 2 additions & 6 deletions src/app/clusters/basic/basic.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -305,8 +305,7 @@ CHIP_ERROR BasicAttrAccess::Write(const ConcreteDataAttributePath & aPath, Attri
{
case Location::Id: {
CHIP_ERROR err = WriteLocation(aDecoder);
// TODO: Attempt to diagnose Darwin CI, REMOVE ONCE FIXED
ChipLogError(Zcl, "WriteLocation status: %" CHIP_ERROR_FORMAT, err.Format());

return err;
}
default:
Expand All @@ -322,9 +321,6 @@ CHIP_ERROR BasicAttrAccess::WriteLocation(AttributeValueDecoder & aDecoder)

ReturnErrorOnFailure(aDecoder.Decode(location));

// TODO: Attempt to diagnose Darwin CI, REMOVE ONCE FIXED
ChipLogError(Zcl, "WriteLocation received, size %zu, location '%.*s'", location.size(), (int) location.size(), location.data());

bool isValidLength = location.size() == DeviceLayer::ConfigurationManager::kMaxLocationLength;
VerifyOrReturnError(isValidLength, StatusIB(Protocols::InteractionModel::Status::InvalidValue).ToChipError());

Expand All @@ -333,7 +329,7 @@ CHIP_ERROR BasicAttrAccess::WriteLocation(AttributeValueDecoder & aDecoder)

class PlatformMgrDelegate : public DeviceLayer::PlatformManagerDelegate
{
// Gets called by the current Node after completing a boot or reboot process.
// Gets called by the current Node after completing a boot or reboot process
void OnStartUp(uint32_t softwareVersion) override
{
ChipLogProgress(Zcl, "PlatformMgrDelegate: OnStartUp");
Expand Down

0 comments on commit 2220354

Please sign in to comment.