Skip to content

Commit

Permalink
Fix missing argument conversion in generate.py script (#24497)
Browse files Browse the repository at this point in the history
* Fix locking logic

* Restyle

* Remove more test code

* Add more arguments that we not working before

* Restyle
  • Loading branch information
andy31415 authored and pull[bot] committed Oct 12, 2023
1 parent 70f264a commit 1815953
Showing 1 changed file with 9 additions and 2 deletions.
11 changes: 9 additions & 2 deletions scripts/tools/zap/generate.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
#

import argparse
import fcntl
import json
import os
import subprocess
Expand Down Expand Up @@ -148,7 +149,13 @@ def runArgumentsParser() -> CmdLineArgs:
templates_file = getFilePath(args.templates)
output_dir = getDirPath(output_dir)

return CmdLineArgs(zap_file, zcl_file, templates_file, output_dir, args.run_bootstrap)
return CmdLineArgs(
zap_file, zcl_file, templates_file, output_dir, args.run_bootstrap,
parallel=args.parallel,
prettify_output=args.prettify_output,
version_check=args.version_check,
lock_file=args.lock_file,
)


def extractGeneratedIdl(output_dir, zap_config_path):
Expand Down Expand Up @@ -276,7 +283,7 @@ def __exit__(self, *args):
return

fcntl.lockf(self.lock_file, fcntl.LOCK_UN)
close(self.lock_file)
self.lock_file.close()
self.lock_file = None


Expand Down

0 comments on commit 1815953

Please sign in to comment.