Remove PluginCallbacks.h header, remove ClientInit callbacks (weak li…

…nkage) (#23299)

* Remove `PluginCallbacks` generated file.

This file is not really needed by anything except advance
declaration by PluginApplicationCallbachs.h. We can codegen the
callbacks in that file.

* Remove ClientInitCallback

scripts/idl/generators/cpp/application/PluginApplicationCallbacksHeader.jinja

@@ -1,9 +1,13 @@
 #pragma once
 
-#include <app-common/zap-generated/callbacks/PluginCallbacks.h>
+{%- for cluster in clusters | serverClustersOnly | sort(attribute='name') %}
+void Matter{{ cluster.name }}PluginServerInitCallback();
+{%- endfor %}
 
 #define MATTER_PLUGINS_INIT \
-{%- for cluster in clusters | sort(attribute='name') %}
-    Matter{{ cluster.name }}Plugin{{ cluster.side | clusterSideString }}InitCallback();{{ " \\" if not loop.last else ""}}
+{%- for cluster in clusters | serverClustersOnly | sort(attribute='name') %}
+    Matter{{ cluster.name }}PluginServerInitCallback();{{ " \\" if not loop.last else ""}}
+{%- else %}
+    (void)0; /* No server side clusters */
 {%- endfor %}
 

scripts/idl/generators/cpp/application/__init__.py

@@ -23,13 +23,8 @@
 import logging
 
 
-def clusterSideString(side: ClusterSide):
-    if side == ClusterSide.CLIENT:
-        return "Client"
-    elif side == ClusterSide.SERVER:
-        return "Server"
-    else:
-        raise Exception("Unknown cluster side %r" % (side, ))
+def serverClustersOnly(clusters: List[Cluster]) -> List[Cluster]:
+    return [c for c in clusters if c.side == ClusterSide.SERVER]
 
 
 class CppApplicationGenerator(CodeGenerator):
@@ -44,7 +39,7 @@ def __init__(self, storage: GeneratorStorage, idl: Idl):
         """
         super().__init__(storage, idl)
 
-        self.jinja_env.filters['clusterSideString'] = clusterSideString
+        self.jinja_env.filters['serverClustersOnly'] = serverClustersOnly
 
     def internal_render_all(self):
         """

scripts/idl/tests/outputs/several_clusters/cpp-app/PluginApplicationCallbacks.h

@@ -1,10 +1,6 @@
 #pragma once
-
-#include <app-common/zap-generated/callbacks/PluginCallbacks.h>
+void MatterThirdPluginServerInitCallback();
 
 #define MATTER_PLUGINS_INIT \
-    MatterFirstPluginClientInitCallback(); \
-    MatterSecondPluginClientInitCallback(); \
-    MatterThirdPluginClientInitCallback(); \
     MatterThirdPluginServerInitCallback();
 

src/app/common/templates/templates.json

@@ -78,11 +78,6 @@
             "name": "ZCL print-cluster header",
             "output": "print-cluster.h"
         },
-        {
-            "path": "../../zap-templates/templates/app/callbacks/PluginCallbacks.zapt",
-            "name": "Matter Callbacks header",
-            "output": "callbacks/PluginCallbacks.h"
-        },
         {
             "path": "../../zap-templates/templates/app/attributes/Accessors.zapt",
             "name": "Attributes Accessors header",

src/app/util/attribute-storage.cpp

@@ -27,7 +27,6 @@
 
 #include <app-common/zap-generated/attribute-type.h>
 #include <app-common/zap-generated/callback.h>
-#include <app-common/zap-generated/callbacks/PluginCallbacks.h>
 #include <app-common/zap-generated/ids/Attributes.h>
 
 using namespace chip;