Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm: Update job ttl to make it configurable #695

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions deployment/helm/templates/webhook-cert-autogen.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ metadata:
{{- include "akri.labels" . | nindent 4 }}
app.kubernetes.io/component: admission-webhook
spec:
ttlSecondsAfterFinished: 0
ttlSecondsAfterFinished: {{ .Values.webhookConfiguration.ttlSecondsAfterFinished }}
template:
metadata:
name: {{ .Values.webhookConfiguration.name }}-create
Expand Down Expand Up @@ -149,7 +149,7 @@ metadata:
{{- include "akri.labels" . | nindent 4 }}
app.kubernetes.io/component: admission-webhook
spec:
ttlSecondsAfterFinished: 0
ttlSecondsAfterFinished: {{ .Values.webhookConfiguration.ttlSecondsAfterFinished }}
template:
metadata:
name: {{ .Values.webhookConfiguration.name }}-patch
Expand Down
4 changes: 4 additions & 0 deletions deployment/helm/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -846,6 +846,10 @@ webhookConfiguration:
# base64-encoded CA certificate (PEM) used by Kubernetes to validate the Webhook's certificate, if
# unset, will generate a self-signed certificate valid for 100y
caBundle: null
# ttlSecondsAfterFinished is the number of seconds to wait after the webhook has finished its job
# before the job is cleaned up. Set this to a non-zero value if your CD pipeline (e.g. ArgoCD) hangs and requires a longer
# TTL.
ttlSecondsAfterFinished: 0
image:
# repository is the Akri Webhook for Configurations image reference
repository: ghcr.io/project-akri/akri/webhook-configuration
Expand Down
Loading