Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(agent): correct agent's behavior on Instance deletion #654

Merged
merged 2 commits into from
Sep 11, 2023
Merged

fix(agent): correct agent's behavior on Instance deletion #654

merged 2 commits into from
Sep 11, 2023

Conversation

diconico07
Copy link
Contributor

What this PR does / why we need it:
Make the agent remove itself from the instance nodes list instead of deleting the instance if it's not the last node with access to the device.

Refactored the way we get the AGENT_NODE_NAME to only fetch it once at startup.

This fixes #650.

Special notes for your reviewer:

If applicable:

  • this PR has an associated PR with documentation in akri-docs
  • this PR contains unit tests
  • added code adheres to standard Rust formatting (cargo fmt)
  • code builds properly (cargo build)
  • code is free of common mistakes (cargo clippy)
  • all Akri tests succeed (cargo test)
  • inline documentation builds (cargo doc)
  • all commits pass the DCO bot check by being signed off -- see the failing DCO check for instructions on how to retroactively sign commits

kate-goldenring
kate-goldenring approved these changes Sep 5, 2023
View reviewed changes
Copy link
Contributor

@kate-goldenring kate-goldenring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! just one nit of code reduction in tests but feel free to ignore.

agent/src/util/discovery_operator.rs Outdated Show resolved Hide resolved
@diconico07
fix(agent): correct agent's behavior on Instance deletion
9216d66 
Make the agent remove itself from the instance nodes list instead of
deleting the instance if it's not the last node with access to the
device.

Refactored the way we get the AGENT_NODE_NAME to only fetch it once at
startup.

This fixes project-akri#650.

Signed-off-by: Nicolas Belouin <[email protected]>
@diconico07
Copy link
Contributor Author

/version patch

@github-actions github-actions bot added the version/patch Patch version change is needed label Sep 8, 2023
@github-actions
Update patch version
43a83cf 
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@diconico07 diconico07 merged commit 1c6d383 into project-akri:main Sep 11, 2023
1 check passed
@diconico07 diconico07 deleted the fix-issue-650 branch September 11, 2023 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kate-goldenring kate-goldenring kate-goldenring approved these changes

@bfjelds bfjelds Awaiting requested review from bfjelds bfjelds is a code owner

@jiria jiria Awaiting requested review from jiria jiria is a code owner

@Britel Britel Awaiting requested review from Britel Britel is a code owner

@romoh romoh Awaiting requested review from romoh romoh is a code owner

@adithyaj adithyaj Awaiting requested review from adithyaj adithyaj is a code owner

@johnsonshih johnsonshih Awaiting requested review from johnsonshih johnsonshih is a code owner

Assignees
No one assigned
Labels
version/patch Patch version change is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

A shared device Instance should get deleted only when all discovery handlers lose track of it
2 participants
@diconico07 @kate-goldenring