Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Rust CI actions to maintained ones #581

Merged
merged 2 commits into from
Apr 17, 2023

Conversation

jbpaux
Copy link
Contributor

@jbpaux jbpaux commented Apr 12, 2023

What this PR does / why we need it:
Upgrade the Rust actions not upgraded in PR #548. Switched to other actions as the current ones are not maintained anymore.
Fix #579
Special notes for your reviewer:

If applicable:

  • this PR has an associated PR with documentation in akri-docs
  • this PR contains unit tests
  • added code adheres to standard Rust formatting (cargo fmt)
  • code builds properly (cargo build)
  • code is free of common mistakes (cargo clippy)
  • all Akri tests succeed (cargo test)
  • inline documentation builds (cargo doc)
  • all commits pass the DCO bot check by being signed off -- see the failing DCO check for instructions on how to retroactively sign commits

@jbpaux
Copy link
Contributor Author

jbpaux commented Apr 12, 2023

/add-same-version-label

@github-actions
Copy link
Contributor

👋 Added [same version] label :)!

1 similar comment
@github-actions
Copy link
Contributor

👋 Added [same version] label :)!

@yujinkim-msft
Copy link
Contributor

@jbpaux thank you for this PR! could you please take a look at the failed check error (versioning/build)?

@jbpaux
Copy link
Contributor Author

jbpaux commented Apr 13, 2023

It's just because there was no version specified in the PR. That's why I added the comment but I don't have permission to relaunch the test

@jbpaux
Copy link
Contributor Author

jbpaux commented Apr 15, 2023

If you want to have a look @kate-goldenring :)

@yujinkim-msft yujinkim-msft merged commit 0171597 into project-akri:main Apr 17, 2023
@jbpaux jbpaux deleted the features/upgrade-rust-actions branch April 17, 2023 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate away from using actions-rs
3 participants