udev: Use device specs instead of mounts #576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diconico07
requested review from
bfjelds,
kate-goldenring,
jiria,
Britel,
romoh and
adithyaj
as code owners
|
/version patch |
kate-goldenring
approved these changes
Apr 11, 2023
Device plugin mechanism diffrentiate Mounts, and DeviceSpecs, Mounts should be used to make libraries or tools available to the pod, and DeviceSpecs to make device nodes available to the pod. This commit switch from using Mounts to using DeviceSpec for device nodes. This currently makes Mounts unused. This is related to project-akri#145 Signed-off-by: Nicolas Belouin <[email protected]>
Signed-off-by: Nicolas Belouin <[email protected]>
diconico07
force-pushed
the
use-device-specs
branch
from
af9aa42
to
f0b45f8
Compare
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Device plugin mechanism differentiate Mounts, and DeviceSpecs, Mounts should be used to make libraries or tools available to the pod, and DeviceSpecs to make device nodes available to the pod.
This commit switch from using Mounts to using DeviceSpec for device nodes. This currently makes Mounts unused.
This is related to #145 and fixes a bug related to non-privileged pods reported on Slack
Special notes for your reviewer:
If applicable:
cargo fmt)cargo build)cargo clippy)cargo test)cargo doc)