Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify crictl container runtime in e2e test workflow #559

Merged

Conversation

kate-goldenring
Copy link
Contributor

@kate-goldenring kate-goldenring commented Feb 22, 2023

What this PR does / why we need it:
Currently the e2e tests are failing for K8s due to the container runtime (of containerd) not being specified for crictl. This will hopefully resolve the issue by specifying a runtime as env vars: https://kubernetes.io/docs/tasks/debug/debug-cluster/crictl/#general-usage.

sudo crictl images
  shell: /usr/bin/bash -e {0}
  env:
    pythonLocation: /opt/hostedtoolcache/Python/3.[8](https://github.com/project-akri/akri/actions/runs/4208520783/jobs/7304830454#step:12:8).16/x64
    LD_LIBRARY_PATH: /opt/hostedtoolcache/Python/3.8.16/x64/lib
unpacking ghcr.io/project-akri/akri/agent-full:pr-amd64 (sha256:4c2cdc275ff3756d026cb4e743675a85[9](https://github.com/project-akri/akri/actions/runs/4208520783/jobs/7304830454#step:12:9)4fccf44705253585fe31cb8476eb9b4)...done
unpacking ghcr.io/project-akri/akri/controller:pr-amd64 (sha256:9963[10](https://github.com/project-akri/akri/actions/runs/4208520783/jobs/7304830454#step:12:10)3feed28bc031750bc75a6b3373f4db32c32efb5d5[11](https://github.com/project-akri/akri/actions/runs/4208520783/jobs/7304830454#step:12:11)850975e4ba2cb39)...done
unpacking ghcr.io/project-akri/akri/webhook-configuration:pr-amd64 (sha256:36de67b2f1f67f931978f159dc0fb7b8ed891749[14](https://github.com/project-akri/akri/actions/runs/4208520783/jobs/7304830454#step:12:15)310d21a693eb8bdad28a05)...done
time="2023-02-18T00:21:19Z" level=warning msg="image connect using default endpoints: [unix:///var/run/dockershim.sock unix:///run/containerd/containerd.sock unix:///run/crio/crio.sock unix:///var/run/cri-dockerd.sock]. As the default settings are now deprecated, you should set the endpoint instead."
E0218 00:21:19.037[15](https://github.com/project-akri/akri/actions/runs/4208520783/jobs/7304830454#step:12:16)1    5389 remote_image.go:119] "ListImages with filter from image service failed" err="rpc error: code = Unavailable desc = connection error: desc = \"transport: Error while dialing dial unix /var/run/dockershim.sock: connect: no such file or directory\"" filter="&ImageFilter{Image:&ImageSpec{Image:,Annotations:map[string]string{},},}"
time="2023-02-18T00:21:19Z" level=fatal msg="listing images: rpc error: code = Unavailable desc = connection error: desc = \"transport: Error while dialing dial unix /var/run/dockershim.sock: connect: no such file or directory\""

Special notes for your reviewer:

If applicable:

  • this PR has an associated PR with documentation in akri-docs
  • this PR contains unit tests
  • added code adheres to standard Rust formatting (cargo fmt)
  • code builds properly (cargo build)
  • code is free of common mistakes (cargo clippy)
  • all Akri tests succeed (cargo test)
  • inline documentation builds (cargo doc)
  • all commits pass the DCO bot check by being signed off -- see the failing DCO check for instructions on how to retroactively sign commits

@adithyaj
Copy link
Collaborator

great catch, thanks for fixing this Kate!

@adithyaj adithyaj merged commit f2c69bd into project-akri:main Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants