-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Ubuntu agent version #546
Merged
adithyaj
merged 6 commits into
project-akri:main
from
jbpaux:features/upgrade-ubuntu-agent-version
Jan 3, 2023
Merged
Upgrade Ubuntu agent version #546
adithyaj
merged 6 commits into
project-akri:main
from
jbpaux:features/upgrade-ubuntu-agent-version
Jan 3, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jean-Benoit Paux <[email protected]>
Signed-off-by: Jean-Benoit Paux <[email protected]>
Signed-off-by: Jean-Benoit Paux <[email protected]>
Signed-off-by: Jean-Benoit Paux <[email protected]>
Signed-off-by: Jean-Benoit Paux <[email protected]>
jbpaux
requested review from
bfjelds,
kate-goldenring,
jiria,
Britel,
romoh and
adithyaj
as code owners
December 28, 2022 14:37
Thanks for updating this and cleaning up the sudo/k3s workarounds we used to have. It looks good to me! |
adithyaj
approved these changes
Dec 29, 2022
Instead of pushing it as the same version, I think we could bump the patch version since we're now only testing all the supported/non end-of-life versions of K8s and we cleaned up the tests too. @kate-goldenring any suggestion on that? |
kate-goldenring
approved these changes
Dec 31, 2022
/version patch |
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
closes #524
I have :
I think there are quite other things to clean but not part of this PR I will open an issue later.
Special notes for your reviewer:
If applicable:
cargo fmt
)cargo build
)cargo clippy
)cargo test
)cargo doc
)