Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Ubuntu agent version #546

Merged

Conversation

jbpaux
Copy link
Contributor

@jbpaux jbpaux commented Dec 28, 2022

What this PR does / why we need it:
closes #524
I have :

  • Upgraded to latest Ubuntu version
  • Fixed build issues related to these changes (upgrade cgroup for k8s)
  • Cleaned sudo stuff as it gave errors because of locations of kubeconfig and are not needed
  • Removed old K3S hack for 1.16 since weremoved it a while ago

I think there are quite other things to clean but not part of this PR I will open an issue later.

Special notes for your reviewer:

If applicable:

  • this PR has an associated PR with documentation in akri-docs
  • this PR contains unit tests
  • added code adheres to standard Rust formatting (cargo fmt)
  • code builds properly (cargo build)
  • code is free of common mistakes (cargo clippy)
  • all Akri tests succeed (cargo test)
  • inline documentation builds (cargo doc)
  • all commits pass the DCO bot check by being signed off -- see the failing DCO check for instructions on how to retroactively sign commits

@adithyaj
Copy link
Collaborator

Thanks for updating this and cleaning up the sudo/k3s workarounds we used to have. It looks good to me!

@adithyaj
Copy link
Collaborator

Instead of pushing it as the same version, I think we could bump the patch version since we're now only testing all the supported/non end-of-life versions of K8s and we cleaned up the tests too.

@kate-goldenring any suggestion on that?

@adithyaj
Copy link
Collaborator

adithyaj commented Jan 3, 2023

/version patch

@github-actions github-actions bot added the version/patch Patch version change is needed label Jan 3, 2023
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@adithyaj adithyaj merged commit 7d35269 into project-akri:main Jan 3, 2023
@jbpaux jbpaux deleted the features/upgrade-ubuntu-agent-version branch January 4, 2023 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
version/patch Patch version change is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update build agents to latest container dependency versions
3 participants