ListAndWatch only sends device if the list has changed #540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Harrison Tin <[email protected]>
harrison-tin
requested review from
bfjelds,
kate-goldenring,
jiria,
Britel,
romoh and
adithyaj
as code owners
kate-goldenring
requested changes
Nov 17, 2022
| dps.instance_map.lock().await.remove(&dps.instance_name); | ||
| dps.server_ender_sender.clone().send(()).await.unwrap(); | ||
| keep_looping = false; | ||
| if prev_virtual_devices != virtual_devices { |
There was a problem hiding this comment.
This assumes that the discovery handler always returns the devices in the same order. For example, the following assertion fails:
let vec1 = vec![1,2,3];
let vec2 = vec![2,1,3];
assert!(vec1 == vec2);You may consider using HashSets.
There was a problem hiding this comment.
Updated to use a simple looping to compare all virtual devices
Signed-off-by: Harrison Tin <[email protected]>
kate-goldenring
approved these changes
Nov 22, 2022
Signed-off-by: Harrison Tin <[email protected]>
|
@harrison-tin I think with the latest merge there's a clippy error that popped up |
Signed-off-by: Harrison Tin <[email protected]>
|
/version patch |
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
|
@harrison-tin @adithyaj are we good to merge this? |
yep LGTM. I can go ahead and merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Harrison Tin [email protected]
What this PR does / why we need it:
As suggested here, the change keeps a vector of previously returned virtual devices and only send updates to kubelet if the list has changed.
It closes #379
Special notes for your reviewer:
Test: passed all unit tests, and manually tested it with some debug messages.
If applicable:
cargo fmt)cargo build)cargo clippy)cargo test)cargo doc)