-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add nodeSelectors for Akri Agent #536
Merged
kate-goldenring
merged 5 commits into
project-akri:main
from
jbpaux:features/add-node-selector
Dec 2, 2022
Merged
Add nodeSelectors for Akri Agent #536
kate-goldenring
merged 5 commits into
project-akri:main
from
jbpaux:features/add-node-selector
Dec 2, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jean-Benoit Paux <[email protected]>
jbpaux
requested review from
bfjelds,
kate-goldenring,
jiria,
Britel,
romoh and
adithyaj
as code owners
November 3, 2022 17:46
/version patch |
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kate-goldenring
approved these changes
Nov 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jbpaux!
Also verified this works selecting for nodename on my cluster with the following:
helm package deployment/helm
helm install akri akri-0.8.25.tgz --set 'agent.nodeSelectors.kubernetes\.io/hostname=kagold-thinkpad-x1-carbon-6th' --set useLatestContainers=true
Hi, |
Thanks for the bump @jbpaux. This is good to merge -- once we bump the version to |
/version patch |
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
/version patch |
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
It adds nodeSelectors on the Agent to ensure the pod is deployed on specific node.
It closes #414
Special notes for your reviewer:
If applicable:
cargo fmt
)cargo build
)cargo clippy
)cargo test
)cargo doc
)