rust toolchain version update #482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romoh
requested review from
bfjelds,
kate-goldenring,
jiria and
Britel
as code owners
Signed-off-by: Roaa Sakr <[email protected]>
Signed-off-by: Roaa Sakr <[email protected]>
Signed-off-by: Roaa Sakr <[email protected]>
Merged
Signed-off-by: Roaa Sakr <[email protected]>
Signed-off-by: Roaa Sakr <[email protected]>
bfjelds
approved these changes
Jun 15, 2022
kate-goldenring
requested changes
Jun 15, 2022
There was a problem hiding this comment.
Thanks for pushing this up! Just a couple more spots we need the version increased: cargo.tomls and the badge in the base readme. After this merges, we need to also update the docs to point to htis latest version too: project-akri/akri-docs#22
discovery-handler-modules/debug-echo-discovery-handler/Cargo.toml
Outdated
Show resolved
Hide resolved
Signed-off-by: Roaa Sakr <[email protected]>
|
Looks like the tarpaulin version may need to be increased or parameterized to use the correct rust version: https://github.com/xd009642/tarpaulin |
Signed-off-by: Roaa Sakr <[email protected]>
For now updated the version and will see if that helps. I'll poke around more. |
kate-goldenring
approved these changes
Jun 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Updates the toolchain version. This is required to ingest new updated dependencies that requires a more recent version of rustc.