Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move documentation out of Akri's main repository [SAME VERSION] #360

Merged
merged 2 commits into from
Aug 13, 2021

Conversation

kate-goldenring
Copy link
Contributor

What this PR does / why we need it:
Akri's documentation has been moved to a separate repository deislabs/akri-docs. This removes all of the documentation and media that has been transferred to that repository. Namely:

  • Documentation under akri/docs/ was either moved to akri-docs/docs, akri-docs/proposals, or Akri's HackMD
  • Image files under akri/docs/media were moved to akri-docs/media
  • Logo files under akri/art were moved to akri-docs/art

Also updates README and Pull Request template to point to Akri's documentation on it's documentation site docs.akri.sh.

Special notes for your reviewer:
With this PR will commence the convention to put documentation for a PR in a separate PR into our documentation repository, which is noted in the PR template.
Note: README points to Raspberry Pi demo endpoint that will exist once project-akri/akri-docs#1 is merged

@kate-goldenring kate-goldenring added the documentation Improvements or additions to documentation label Aug 10, 2021
@bfjelds
Copy link
Collaborator

bfjelds commented Aug 11, 2021

this looks good to me ... the only other link to docs i see in my repo is for gh-pages' index.md (https://github.com/deislabs/akri/blob/gh-pages/index.md)

@jiria
Copy link
Contributor

jiria commented Aug 12, 2021

FYI the PR that you linked for rpi demo is merged, yet the rpi demo url is still not working. https://docs.akri.sh/demos/usb-camera-demo-rpi4

@kate-goldenring
Copy link
Contributor Author

FYI the PR that you linked for rpi demo is merged, yet the rpi demo url is still not working. https://docs.akri.sh/demos/usb-camera-demo-rpi4

Yeah that is because the site is still pointing at my fork. I need to get appropriate permissions from Deis Labs folks to switch it, so this PR is one hold until that happens

@kate-goldenring
Copy link
Contributor Author

this looks good to me ... the only other link to docs i see in my repo is for gh-pages' index.md (https://github.com/deislabs/akri/blob/gh-pages/index.md)

@bfjelds good point. Put in a PR to update gh-pages too: #362

@kate-goldenring kate-goldenring changed the title Move documentation out of Akri's main repository Move documentation out of Akri's main repository [SAME VERSION] Aug 12, 2021
@@ -8,7 +8,7 @@ spec:
name: udev
discoveryDetails: |+
udevRules:
{{- required "Please set at least one udev rule with `--set udev.configuration.discoveryDetails.udevRules[0]==\"<udev rule>\"' to specify what you want discovered. See the udev Configuration document at https://github.com/deislabs/akri/blob/main/docs/udev-configuration.md for more information." .Values.udev.configuration.discoveryDetails.udevRules | toYaml | nindent 6 }}
{{- required "Please set at least one udev rule with `--set udev.configuration.discoveryDetails.udevRules[0]==\"<udev rule>\"' to specify what you want discovered. See the udev Configuration document at https://docs.akri.sh/discovery-handlers/udev for more information." .Values.udev.configuration.discoveryDetails.udevRules | toYaml | nindent 6 }}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change to the template is what is kicking off the end to end tests. I think it makes sense to still not do a version update. This log will be updated in a later chart.

@kate-goldenring kate-goldenring merged commit b856d74 into project-akri:main Aug 13, 2021
@kate-goldenring kate-goldenring deleted the remove-docs branch August 13, 2021 04:23
vincepnguyen pushed a commit that referenced this pull request Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants