Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase docker create timeout to 600 minutes and document this hidden timeout #267

Merged
merged 12 commits into from
Mar 9, 2021
Merged

Increase docker create timeout to 600 minutes and document this hidden timeout #267

Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
3ba07a2
Try same env var for action and container timeout
bfjelds Mar 9, 2021
2235e8e
output script to verify
bfjelds Mar 9, 2021
87e7ca7
try reusing timeout-minutes directly
bfjelds Mar 9, 2021
a53594c
Try moving timeout to step and access that directly
bfjelds Mar 9, 2021
5bd7b0c
try fixing env var creation
bfjelds Mar 9, 2021
d82dd0a
try using env var again
bfjelds Mar 9, 2021
7f907d5
Use step.timeout-minutes because it can pull from env var
bfjelds Mar 9, 2021
f948b6c
Update run-tarpaulin.yml
bfjelds Mar 9, 2021
da6fed9
just make the docker keep alive script sleep 600 minutes
bfjelds Mar 9, 2021
2a3d48a
remove env var
bfjelds Mar 9, 2021
7ca3292
fix typo
bfjelds Mar 9, 2021
f5fa411
typos, typos, typos
bfjelds Mar 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion .github/workflows/run-tarpaulin.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,13 @@ env:
jobs:
build:
runs-on: ubuntu-latest
# There is a second, hidden timeout in this workflow. When the tarpaulin container is created,
# it is created with a CMD that sleeps for 600 minutes. A more reasonable value could be selected,
# but it seems easier to make it SOOOO big that timeout-minutes is likely to never be impacted by
# it.
#
# But, if this workflow is mysteriously timing out after 600 minutes, make changes to the docker
# create command in the Create tarpaulin instance step.
timeout-minutes: 30

steps:
Expand All @@ -29,7 +36,7 @@ jobs:
persist-credentials: false

- name: Create tarpaulin instance
run: docker create --network host --security-opt seccomp=unconfined -v "${PWD}:/volume" xd009642/tarpaulin:0.16.0 bash -c "echo 'sleep 20m; echo bye' > /tmp/keep_alive.sh; chmod 777 /tmp/keep_alive.sh; /tmp/keep_alive.sh" > container_id.txt
run: docker create --network host --security-opt seccomp=unconfined -v "${PWD}:/volume" xd009642/tarpaulin:0.16.0 bash -c "echo 'sleep 600m; echo bye' > /tmp/keep_alive.sh; chmod 777 /tmp/keep_alive.sh; /tmp/keep_alive.sh" > container_id.txt
- name: Start tarpaulin instance
run: docker start $(cat container_id.txt)
- name: Install linux requirement in tarpaulin instance
Expand Down