Skip to content

Commit

Permalink
Lazy eval of makefile timestamp breaks local build [SAME VERSION] [IG…
Browse files Browse the repository at this point in the history
…NORE INTERMEDIATE BUILDS] (#242)
  • Loading branch information
bfjelds authored Feb 9, 2021
1 parent 55daf10 commit fd2ed66
Showing 1 changed file with 6 additions and 2 deletions.
8 changes: 6 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,12 @@ INTERMEDIATE_DOCKERFILE_DIR ?= build/containers/intermediate
DOCKERFILE_DIR ?= build/containers

PREFIX ?= $(REGISTRY)/$(UNIQUE_ID)
VERSION=$(shell cat version.txt)
TIMESTAMP=$(shell date +"%Y%m%d_%H%M%S")

# Evaluate VERSION and TIMESTAMP immediately to avoid
# any lazy evaluation change in the values
VERSION := $(shell cat version.txt)
TIMESTAMP := $(shell date +"%Y%m%d_%H%M%S")

VERSION_LABEL=v$(VERSION)-$(TIMESTAMP)
LABEL_PREFIX ?= $(VERSION_LABEL)

Expand Down

0 comments on commit fd2ed66

Please sign in to comment.