-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set up GitHub actions for CI and release builds #1667
Conversation
@HonkingGoose how does this look? I'm afraid it's hard to test at this point without merging. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it looks OK, as far as I can tell. Some small niggles.
I agree, it's probably easiest to debug while running it for real, at least then you can see the output and tune things that are not working properly. 😄 You could copy/clone this repository into a new "throwaway/trial" repository, and run the actions on there? |
I notice we have some differences between this PR, the Are you sure this PR contains all the parts you need? I saw you did something with the git fetch depth on the |
By the way the According to: https://github.com/ben/progit2-test/actions/runs/976418220
|
I think this is because kindlegen isn't there? I'm completely fried from driving all day and this 112° heat. I'll take another look in the morning. Also, sadly, creating a tag with the API doesn't cause a |
The
Maybe this download is not working properly on CI systems? Or could be caused by something else. 😄 |
Boom, here's a release created by these actions. It doesn't include the .mobi, because it says it can't find kindlegen. Not really sure what's going on there. |
I'm tempted to merge this just so we can get releases flowing again, then follow up with a kindlegen fix and cleaning up our Travis mess. |
Sounds good! |
Changes
This sets up GitHub actions to be our book-build provider. Fixes #1566.
master
master