Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up GitHub actions for CI and release builds #1667

Merged
merged 18 commits into from
Jun 28, 2021
Merged

Conversation

ben
Copy link
Member

@ben ben commented Jun 27, 2021

Changes

This sets up GitHub actions to be our book-build provider. Fixes #1566.

  • Action to build artifacts on PRs and merges to master
  • Action to tag on merges to master
  • Action to create a release when a new tag is pushed

@ben
Copy link
Member Author

ben commented Jun 27, 2021

@HonkingGoose how does this look? I'm afraid it's hard to test at this point without merging.

Copy link
Contributor

@HonkingGoose HonkingGoose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it looks OK, as far as I can tell. Some small niggles.

@HonkingGoose
Copy link
Contributor

I'm afraid it's hard to test at this point without merging.

I agree, it's probably easiest to debug while running it for real, at least then you can see the output and tune things that are not working properly. 😄

You could copy/clone this repository into a new "throwaway/trial" repository, and run the actions on there?

@HonkingGoose
Copy link
Contributor

HonkingGoose commented Jun 27, 2021

I notice we have some differences between this PR, the progit2-test/master branch, and the progit2-test/ben-github-actions branch.

Are you sure this PR contains all the parts you need? I saw you did something with the git fetch depth on the progit2-test/master branch for example.

@HonkingGoose
Copy link
Contributor

@ben Might want to put Fixes #1566 in the top post, so that that issue gets closed when you merge this PR.

See issue: #1566.

@HonkingGoose
Copy link
Contributor

By the way the .mobi files are not getting released properly on your test repo. Maybe there's a problem with the link to the file?

According to: https://github.com/ben/progit2-test/actions/runs/976418220

tag
Artifact pattern :./progit.mobi did not match any files

@ben
Copy link
Member Author

ben commented Jun 28, 2021

.mobi files are not getting released properly

I think this is because kindlegen isn't there? I'm completely fried from driving all day and this 112° heat. I'll take another look in the morning.

Also, sadly, creating a tag with the API doesn't cause a push event, so I'll have to collapse the "tag on merge to master" and "create release on tag" jobs into one. Too bad.

@HonkingGoose
Copy link
Contributor

I think this is because kindlegen isn't there? I'm completely fried from driving all day and this 112° heat. I'll take another look in the morning.

The asciidoctor-epub3 package "includes" Kindlegen by downloading it from someplace else, quote from latest release notes for the package (which we already merged):

Possibly even more exciting feature of this release is that Kindlegen is back! Even though Amazon dropped Kindlegen from its webservers, what was put on the Internets stays there forever. Thanks to The Wayback Machine that remembers (almost) everything, we can use it to download Kindlegen binaries.

#1646 (comment)

Maybe this download is not working properly on CI systems? Or could be caused by something else. 😄

@ben
Copy link
Member Author

ben commented Jun 28, 2021

Boom, here's a release created by these actions. It doesn't include the .mobi, because it says it can't find kindlegen. Not really sure what's going on there.

@ben
Copy link
Member Author

ben commented Jun 28, 2021

I'm tempted to merge this just so we can get releases flowing again, then follow up with a kindlegen fix and cleaning up our Travis mess.

@HonkingGoose
Copy link
Contributor

I'm tempted to merge this just so we can get releases flowing again, then follow up with a kindlegen fix and cleaning up our Travis mess.

Sounds good!

@ben ben merged commit 4b99f21 into master Jun 28, 2021
@ben ben deleted the ben/github-actions branch June 28, 2021 14:55
@ben ben mentioned this pull request Jun 28, 2021
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate away from travis-ci.org
2 participants