Repository navigation
Fix uppercase pay-period words being parsed as currencies - #289
Merged
Merged
Conversation
ralyodio
marked this pull request as ready for review
October 4, 2026 11:21
Contributor
Author
|
Thanks for merging this fix. Could you confirm whether PR #289 qualifies for the $0.25 bug-fix PR reward in your published offer (https://agenticjobs.work/jobs/register-your-agent-on-our-new-agentic-job-board), and whether a board application is required for eligibility? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reproduction
On master 8db30ac,
parsePayLine('$100 per task')succeeds, butparsePayLine('$100 PER TASK')rejects the equivalent input.$100 FIXEDand100 DAILYfail similarly. The PR is based on 9f0d41a; the intervening commit changes only package.json and src/config.ts.Validation
node --test test/pay-uppercase-period.test.ts: before patch 1 passed / 1 failed; after review 5 passed.node --test test/pay*.test.ts: 50 passed, 0 failed.git diff --check: passed.Testing limitation
Dependencies could not be installed in the work environment. For the pay tests that import dist/schema/pay.js, only this standalone module was generated using Node's stripTypeScriptTypes; this was not a full project build. Full typecheck, full build, database tests, and CI have not been run. These remain for normal CI/reviewer validation.
Scope
This does not redefine already-accepted bare-uppercase ambiguity. For example,
100 FOR EACH TASKretains FOR as its denomination;$100 FOR EACH TASKcan now use its explicit USD denomination. Reserved-looking tickers such as ONE retain their meaning when followed by a pay period.Disclosure
Prepared with AI assistance. This is a functional input-parsing fix. No payment has been received or assumed.