Skip to content

Fix uppercase pay-period words being parsed as currencies - #289

Merged
ralyodio merged 2 commits into
profullstack:masterfrom
k1mtruth:fix-uppercase-pay-period
Oct 4, 2026
Merged

ralyodio merged 2 commits into
profullstack:masterfrom
k1mtruth:fix-uppercase-pay-period

Conversation

@k1mtruth

@k1mtruth k1mtruth commented Oct 4, 2026

Copy link
Copy Markdown
Contributor

Summary

  • When ordinary parsing fails, retry complete case-insensitive period and flat-fee suffixes rather than consuming them as unknown currency tickers. Preserve every successful ordinary parse, including ambiguous uppercase ticker expressions.
  • Add regression coverage for uppercase hourly/task/week/daily and flat-fee expressions, ranges, currency preservation, and conflicting currencies.

Reproduction

On master 8db30ac, parsePayLine('$100 per task') succeeds, but parsePayLine('$100 PER TASK') rejects the equivalent input. $100 FIXED and 100 DAILY fail similarly. The PR is based on 9f0d41a; the intervening commit changes only package.json and src/config.ts.

Validation

  • node --test test/pay-uppercase-period.test.ts: before patch 1 passed / 1 failed; after review 5 passed.
  • node --test test/pay*.test.ts: 50 passed, 0 failed.
  • git diff --check: passed.

Testing limitation

Dependencies could not be installed in the work environment. For the pay tests that import dist/schema/pay.js, only this standalone module was generated using Node's stripTypeScriptTypes; this was not a full project build. Full typecheck, full build, database tests, and CI have not been run. These remain for normal CI/reviewer validation.

Scope

This does not redefine already-accepted bare-uppercase ambiguity. For example, 100 FOR EACH TASK retains FOR as its denomination; $100 FOR EACH TASK can now use its explicit USD denomination. Reserved-looking tickers such as ONE retain their meaning when followed by a pay period.

Disclosure

Prepared with AI assistance. This is a functional input-parsing fix. No payment has been received or assumed.

@ralyodio
ralyodio marked this pull request as ready for review October 4, 2026 11:21
@ralyodio
ralyodio merged commit 6dea4fc into profullstack:master Oct 4, 2026
2 checks passed
@k1mtruth

k1mtruth commented Oct 4, 2026

Copy link
Copy Markdown
Contributor Author

Thanks for merging this fix. Could you confirm whether PR #289 qualifies for the $0.25 bug-fix PR reward in your published offer (https://agenticjobs.work/jobs/register-your-agent-on-our-new-agentic-job-board), and whether a board application is required for eligibility?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants