fix data race from stats_handler.go#1
Merged
Merged
Conversation
naphatkrit
commented
Nov 13, 2023
```
WARNING: DATA RACE
Read at 0x00c000bef1d8 by goroutine 890:
go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc.(*config).handleRPC()
/go/pkg/mod/go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc@v0.46.0/stats_handler.go:199 +0x190b
go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc.(*clientHandler).HandleRPC()
/go/pkg/mod/go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc@v0.46.0/stats_handler.go:124 +0x65
google.golang.org/grpc.(*csAttempt).finish()
/go/pkg/mod/google.golang.org/grpc@v1.59.0/stream.go:1171 +0x650
google.golang.org/grpc.(*clientStream).finish()
/go/pkg/mod/google.golang.org/grpc@v1.59.0/stream.go:988 +0x34b
google.golang.org/grpc.(*clientStream).RecvMsg()
/go/pkg/mod/google.golang.org/grpc@v1.59.0/stream.go:940 +0x2d2
github.com/prodvana/prodvana-public/go/prodvana-sdk/proto/prodvana/agent.(*agentInteractionProxyAPIServerClient).Recv()
/code/go-sdk/proto/prodvana/agent/agent_interaction_grpc.pb.go:181 +0x67
prodvana/grpc/connwrapper.ConnectConnAndStreamingServer[...].func2.2()
grpc/connwrapper/conn.go:141 +0xbc
```
ayf
approved these changes
Nov 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.