Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build info for new node version #38

Merged
merged 13 commits into from
Jul 17, 2017

Conversation

nghiant2710
Copy link
Contributor

No description provided.

&& git checkout ${commit[0]} \
&& ./configure --prefix=/ --shared-zlib --shared-openssl \
&& make -j$(nproc) -C out mksnapshot \
&& paxctl -c -m out/Release/mksnapshot \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need to modify PaX settings here? We're not using PaX anywhere AFAIK

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nghiant2710 I don' t think we need these. This is only if you're running a Grsecurity/PaX kernel, which we don't and the project also stopped being public. nodejs/build#75 (comment)

@Page- Page- removed their request for review June 12, 2017 23:35
@kennethlimcp
Copy link

Will this be available soon? :)

&& git checkout ${commit[0]} \
&& ./configure --prefix=/ --shared-zlib --shared-openssl \
&& make -j$(nproc) -C out mksnapshot \
&& paxctl -c -m out/Release/mksnapshot \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nghiant2710 I don' t think we need these. This is only if you're running a Grsecurity/PaX kernel, which we don't and the project also stopped being public. nodejs/build#75 (comment)

@nghiant2710 nghiant2710 force-pushed the master branch 3 times, most recently from 12bec32 to 2cb717c Compare July 6, 2017 05:46
@nghiant2710 nghiant2710 merged commit 8626aae into product-os:master Jul 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants