-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add build info for new node version #38
Conversation
alpine/aarch64/build.sh
Outdated
&& git checkout ${commit[0]} \ | ||
&& ./configure --prefix=/ --shared-zlib --shared-openssl \ | ||
&& make -j$(nproc) -C out mksnapshot \ | ||
&& paxctl -c -m out/Release/mksnapshot \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need to modify PaX settings here? We're not using PaX anywhere AFAIK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@petrosagg, https://git.alpinelinux.org/cgit/aports/tree/main/nodejs/APKBUILD?id=c6acdb11e843e65acf68d71473134149ea4604d3.
I follow the way they build for official package.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nghiant2710 I don' t think we need these. This is only if you're running a Grsecurity/PaX kernel, which we don't and the project also stopped being public. nodejs/build#75 (comment)
Will this be available soon? :) |
alpine/aarch64/build.sh
Outdated
&& git checkout ${commit[0]} \ | ||
&& ./configure --prefix=/ --shared-zlib --shared-openssl \ | ||
&& make -j$(nproc) -C out mksnapshot \ | ||
&& paxctl -c -m out/Release/mksnapshot \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nghiant2710 I don' t think we need these. This is only if you're running a Grsecurity/PaX kernel, which we don't and the project also stopped being public. nodejs/build#75 (comment)
12bec32
to
2cb717c
Compare
No description provided.