Add NODE_OPTIONS to Dockerfile and rm from README

product-os · Feb 13, 2020 · a74dc65 · a74dc65
1 parent 8e9e777
commit a74dc65
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 20 deletions.
diff --git a/README.md b/README.md
@@ -46,24 +46,6 @@ Run them with:
 make compose-up
 ```
 
-If webpack throws memory error, set NODE_OPTIONS in app/ui/Dockefile
-
-Error:
-`FATAL ERROR: Ineffective mark-compacts near heap limit Allocation failed - JavaScript heap out of memory`
-
-Setting NODE_OPTIONS:
-
-```
-    RUN make build-ui \
-    NODE_ENV=production \
-    COVERAGE=${ENABLE_COVERAGE} \
-    SENTRY_DSN_UI=$SENTRY_DSN_UI \
-    SERVER_HOST=$SERVER_HOST \
-    SERVER_PORT=$SERVER_PORT \
-    OAUTH_REDIRECT_BASE_URL=https://jel.ly.fish \
-    NODE_OPTIONS=--max-old-space-size=2048
-```
-
 Add endpoints to local hosts file:
 
 ```

diff --git a/apps/ui/Dockerfile b/apps/ui/Dockerfile
@@ -34,8 +34,8 @@ RUN make build-ui \
 	SENTRY_DSN_UI=$SENTRY_DSN_UI \
 	SERVER_HOST=$SERVER_HOST \
 	SERVER_PORT=$SERVER_PORT \
-	OAUTH_REDIRECT_BASE_URL=https://jel.ly.fish
-
+	OAUTH_REDIRECT_BASE_URL=https://jel.ly.fish \
+	NODE_OPTIONS=--max-old-space-size=2048
 ###########################################################
 # Runtime
 ###########################################################