You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Here is the suspected order of events where a problem may occur:
PR is closed manually for any number of reasons (unmerged)
PR close event triggers the workflow and runs the Custom Clean job, and maybe some others
At some point in the future, the PR is reopened manually or by Renovate
Flowzone workflows are not currently triggered by reopen event types so nothing happens
The last successful workflow run at this point was on the previous close event, so the All jobs required step has a result of skipped
Jobs with a skipped result are unusually considered to be passing in branch protections, so at this point the PR can be merged manually by clicking Merge
The possible solutions vary:
Run All jobs on all event types, but mark as failed if the PR is not open
Run workflow on reopen events (this requires changing the calling workflows in 100s of repositories)
???
The core of this issue seems to be that Github PR triggers do not include closed (including merged) events by default, and they must be added. Combine this with the fact that Github treats skipped jobs as meeting merge requirements puts us in this situation.
The text was updated successfully, but these errors were encountered:
klutchell
changed the title
Re-opened PRs can potentially bypass merge requirements
Re-opened PRs can potentially merge requirements
Jul 31, 2024
This job is used for branch requirements, and
we don't want it to show as skipped in case the PR
is ever reopened.
See: #1143
Change-type: minor
Signed-off-by: Kyle Harding <[email protected]>
This job is used for branch requirements, and
we don't want it to show as skipped in case the PR
is ever reopened.
See: #1143
Change-type: minor
Signed-off-by: Kyle Harding <[email protected]>
Discussion: https://balena.zulipchat.com/#narrow/stream/348930-balena-io.2Fflowzone/topic/Flowzone.20skipped.20almost.20everything/near/455074162
Here is the suspected order of events where a problem may occur:
reopen
event types so nothing happensAll jobs
required step has a result ofskipped
The possible solutions vary:
All jobs
on all event types, but mark as failed if the PR is not openThe core of this issue seems to be that Github PR triggers do not include closed (including merged) events by default, and they must be added. Combine this with the fact that Github treats skipped jobs as meeting merge requirements puts us in this situation.
The text was updated successfully, but these errors were encountered: