Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ability to customize the library's C++ namespace (default is lbstd) #15

Closed
2 tasks done
leha-bot opened this issue Sep 12, 2022 · 0 comments · Fixed by #16
Closed
2 tasks done

Ability to customize the library's C++ namespace (default is lbstd) #15

leha-bot opened this issue Sep 12, 2022 · 0 comments · Fixed by #16
Assignees
@leha-bot
Labels
enhancement New feature or request
Milestone
0.0.x

Comments

@leha-bot
Copy link
Member

leha-bot commented Sep 12, 2022 •
edited
Loading

via CMake's configure argument -DLBSTD_VERSION_NS=<custom_namespace>
The macro for name of namespace will be LB_STD_VERSION_NS (with underscore, inconsistent, yes).
Another tasks:

  • Passthrough the CMake arg to C++ #define;
  • Test in tests/CMakeLists.txt for checking the baked C++ namespace's name with baked into CMake;
@leha-bot leha-bot added the enhancement New feature or request label Sep 12, 2022
@leha-bot leha-bot added this to the 0.0.x milestone Sep 12, 2022
@leha-bot leha-bot self-assigned this Sep 12, 2022
@leha-bot leha-bot mentioned this issue Sep 12, 2022
Merged
leha-bot added a commit that referenced this issue Sep 23, 2023
@leha-bot
feat(cmake): pass-through the custom C++ namespace from CMake (#15)
7de2a39 
Via defining the LB_STD_VERSION_NS macro using the
target_compile_definitions().
Its name a bit inconsistent though, but looks better (in my opinion) in
C++, but doesn't look OK in a bunch of CMake configure parameters as it
conflicts with another flags (`LBSTD_VERSION_xxx` vs `LB_STD_VERSION_xxx`).
leha-bot added a commit that referenced this issue Sep 23, 2023
@leha-bot
feat(cmake): pass-through the custom C++ namespace from CMake (#15)
06a11f9 
Via defining the LB_STD_VERSION_NS macro using the
target_compile_definitions().
Its name a bit inconsistent though, but looks better (in my opinion) in
C++, but doesn't look OK in a bunch of CMake configure parameters as it
conflicts with another flags (`LBSTD_VERSION_xxx` vs `LB_STD_VERSION_xxx`).
@leha-bot leha-bot mentioned this issue Sep 23, 2023
Open
leha-bot added a commit that referenced this issue Sep 23, 2023
@leha-bot
feat(cmake): pass-through the custom C++ namespace from CMake (#15)
c2d9fa9 
Via defining the LB_STD_VERSION_NS macro using the
target_compile_definitions().
Its name a bit inconsistent though, but looks better (in my opinion) in
C++, but doesn't look OK in a bunch of CMake configure parameters as it
conflicts with another flags (`LBSTD_VERSION_xxx` vs `LB_STD_VERSION_xxx`).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leha-bot leha-bot

Labels
enhancement New feature or request
Projects
Version 0.0.1
Status: Done
Milestone
0.0.x
Development

Successfully merging a pull request may close this issue.

feat: Custom C++ namespace for library (#15) procxx/std_version
1 participant
@leha-bot