Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use AL_DIRECT_CHANNELS_SOFT for audio playback. #219

Merged
merged 1 commit into from
May 24, 2019

Conversation

foxcpp
Copy link
Contributor

@foxcpp foxcpp commented Jan 7, 2019

See telegramdesktop/tdesktop#2580.

(cherry picked from commit e3b6e13)

@vyamkovyi
Copy link

uhh, sure, this will do the trick but AL_DIRECT_CHANNELS_SOFT was designed quite poorly. The intended use here is to avoid direct channels and play via virtual speakers. As I've also mentioned in comment for the original commit, it must be tested on real 5.1 system before I'd like to see it merged. According to my prediction, front-center and surround channels are going to be dropped.

@crackedmind
Copy link
Member

@crackedmind
Copy link
Member

@foxcpp
Copy link
Contributor Author

foxcpp commented Jan 8, 2019

https://github.com/openalext/openalext/wiki/AL_SOFT_direct_channels

AL_DIRECT_CHANNELS_SOFT set to AL_TRUE indicates the audio channels are
not virtualized and play directly on the matching output channels if they
exist, otherwise they are dropped. Applies only when playing non-mono
buffers.

@leha-bot leha-bot merged commit e164760 into procxx:dev May 24, 2019
@foxcpp foxcpp deleted the issue-66 branch May 24, 2019 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants