Use custom application name in tray popup menu #106
Conversation
Update mainwindow.cpp to use parametrized lang calls
|
❌ Build kepka 1.0.74-icnltpwk failed (commit d68a4bc7b2 by @minlexx) |
| @@ -1427,6 +1427,6 @@ Copyright (c) 2014-2017 John Preston, https://desktop.telegram.org | |||
| "lng_mac_menu_add_contact" = "Add Contact"; | |||
| "lng_mac_menu_new_group" = "New Group"; | |||
| "lng_mac_menu_new_channel" = "New Channel"; | |||
| "lng_mac_menu_show" = "Show Telegram"; | |||
| "lng_mac_menu_show" = "Show {telegram}"; | |||
There was a problem hiding this comment.
Mac-specific section contains the following strings:
"lng_mac_menu_hide_telegram" = "Hide {telegram}";
"lng_mac_menu_quit_telegram" = "Quit {telegram}";
"lng_mac_menu_about_telegram" = "About {telegram}";
So I decided to use {telegram} for "lng_mac_menu_show" too.
There was a problem hiding this comment.
I still suggest to replace if with {appname}. Guys, what would you say?
There was a problem hiding this comment.
It will not work, this line change change is bad because mac compilation should fail. Code calling this translation should be fixed as well, both with {telegram} constant or {appname} constant. I can't test build on Mac :)
|
Alright, it looks ok to me 👍 |
|
✅ Build kepka 1.0.74-vnxysiof completed (commit b239809672 by @minlexx) |
it requires to change Mac-specific code
|
✅ Build kepka 1.0.74-jpaxgedp completed (commit 9664dad57c by @minlexx) |
leha-bot
added
category:Enhancement
|
|
Should I update other lang files like lang_de.strings?
"lng_mac_menu_show" change in mac specific section may be unrelated, cannot test with MacOS