Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rpmlint error: Program returns random data in a function #153

Closed
EGD opened this issue Jun 1, 2018 · 5 comments
Closed

rpmlint error: Program returns random data in a function #153

EGD opened this issue Jun 1, 2018 · 5 comments
Labels
category:Enhancement This is a proposed improvement category:Infrastructure Related to build tools, automation category:Refactoring Related to code refactoring
Milestone
Refactoring

Comments

@EGD
Copy link

EGD commented Jun 1, 2018

Actual behaviour

I: Program returns random data in a function
E: kepka no-return-in-nonvoid-function ../Telegram/ThirdParty/libtgvoip/os/linux/AudioInputALSA.cpp:74
E: kepka no-return-in-nonvoid-function ../Telegram/ThirdParty/libtgvoip/os/linux/AudioOutputALSA.cpp:77

Configuration

Operating system:
openSUSE 15.0
Version of Telegram Desktop:
09f8d60
@leha-bot
Copy link
Member

leha-bot commented Jun 1, 2018

Thank you for your issue! This is related to #42 and is a libtgvoip bug. It possibly will be fixed after sync with latest revision. (If not, then we will think about proper fix of that dirty code).

@leha-bot leha-bot added category:Enhancement This is a proposed improvement category:Infrastructure Related to build tools, automation category:Refactoring Related to code refactoring labels Jun 1, 2018
@leha-bot
Copy link
Member

@EGD please recheck last commit from dev branch. @Randl fixed almost all warnings in recently merged pull #157.

leha-bot added a commit that referenced this issue Jun 20, 2018
@leha-bot
libtgvoip: return nullptr to avoid compile error
a7c6201 
Before that commit the function void *AudioInputALSA::StartThread() doesn't return any values. 
Also please note that this fix should be ported after syncing libtgvoip to upstream!

Related to #153.
leha-bot added a commit that referenced this issue Jun 20, 2018
@leha-bot
libtgvoip: return nullptr to avoid compile err p2
38f19bb 
Before that commit the function void *AudioOutputALSA::StartThread() doesn't return any values.  
Also please note that this fix should be ported after syncing libtgvoip to upstream!

Related to #153.
@leha-bot leha-bot mentioned this issue Jun 20, 2018
Merged
@leha-bot leha-bot added this to the Refactoring milestone Jun 20, 2018
leha-bot added a commit that referenced this issue Jun 20, 2018
@leha-bot
Fix "no return in nonvoid function" error in libtgvoip (#167)
0d01360 
Return nullptr to avoid compile error.

Before this commit these functions:
1. void *AudioInputALSA::StartThread();
2. void *AudioOutputALSA::StartThread()
 - don't return any values. 

Also please note that this fix should be ported after syncing libtgvoip to upstream if these functions still don't return values!

Related to #153.
@leha-bot
Copy link
Member

@EGD could you recheck latest dev commit?

@EGD
Copy link
Author

EGD commented Jun 20, 2018

@leha-bot sorry for wait, i probe 9f1896c commit and errors output gone

@leha-bot
Copy link
Member

It's wonderful! Thanks for your feedback, feel free to create new issues, feature requests or pulls.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
category:Enhancement This is a proposed improvement category:Infrastructure Related to build tools, automation category:Refactoring Related to code refactoring
Projects
None yet
Milestone
Refactoring
Development

No branches or pull requests
2 participants
@EGD @leha-bot