Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Russian quote marks and formatting #13

Closed
ForNeVeR opened this issue Nov 28, 2017 · 1 comment
Closed

Russian quote marks and formatting #13

ForNeVeR opened this issue Nov 28, 2017 · 1 comment
Assignees
@ForNeVeR
Labels
category:Bug This is a bug category:Sync Reduce disparity with upstream code category:Upstream Add feature from upstream

Comments

@ForNeVeR
Copy link
Member

ForNeVeR commented Nov 28, 2017 •
edited
Loading

Steps to reproduce

  1. Write the text (**x** y z) in chat ⇒ it formats the x in bold (OK).
  2. Write the same text with Russian quote marks «**x** y z» ⇒ it doesn't format the bold text and leaves * as is (FAIL).

See upstream issue telegramdesktop/tdesktop#3867 for list of additional characters.

Expected behaviour

The Russian quote marks should be considered the same as ordinary braces in context of formatting. x should be bold in both samples.

Actual behaviour

Russian quote marks considered as ordinary text, formatting doesn't work.

Configuration

Operating system: Windows 8.1
Version of Telegram Desktop: 1.1.23
@ForNeVeR ForNeVeR added the category:Bug This is a bug label Nov 28, 2017
@ForNeVeR
Copy link
Member Author

Fixed in upstream: telegramdesktop/tdesktop@2e421e8

@ForNeVeR ForNeVeR self-assigned this Dec 19, 2017
@leha-bot leha-bot added category:Sync Reduce disparity with upstream code category:Upstream Add feature from upstream labels Dec 19, 2017
@ForNeVeR ForNeVeR mentioned this issue Dec 24, 2017
Merged
ForNeVeR added a commit that referenced this issue Dec 24, 2017
@ForNeVeR
Allow unicode quotes as markdown entry separators.
b06f2ef 
Fixes #13.
leha-bot pushed a commit that referenced this issue Dec 24, 2017
@ForNeVeR @leha-bot
Allow unicode quotes as markdown entry separators. (#54)
31ed521 
Fixes #13. (Based on upstream's commit telegramdesktop/tdesktop@2e421e8, )
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ForNeVeR ForNeVeR

Labels
category:Bug This is a bug category:Sync Reduce disparity with upstream code category:Upstream Add feature from upstream
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ForNeVeR @leha-bot