Moved fbo allowed check into PGL. #76
Conversation
Move checking for frame buffer object support from PSurfaceJOGL to PGL, closing a TODO in PGL and removing dependency on reflexive access. Note that this does require subclasses of PGL to use or override getIsFboAllowed instead of direct access to fboAllowed. This will require checking in with @benfry. Resolves #50.
|
Note that this is blocked on #74. |
|
Hey there! There's a few PRs outstanding (with inter-dependencies) and the build on master has been broken on Mac for some time. So, I have an integration branch over at https://github.com/sampottinger/processing4 master. That branch includes this PR. This allows one to use Processing 4 again on a Mac along with all of the recent bug fixes. For your convenience, I have made builds available at https://www.datadrivenempathy.com/processing. |
|
Alternate solution based on this work now here: cc39c94 Thanks for your help! |
|
Just re-opening and merging but with no changes to master to make it easier for dependent PRs |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Move checking for frame buffer object support from
PSurfaceJOGLtoPGL, closing a TODO inPGLand removing dependency on reflexive access. This is done by switching to resolving the check on demand after renderer has initialized. Note that this does require subclasses ofPGLto use or overridegetIsFboAllowedinstead of direct access tofboAllowed. This will require checking in with @benfry.Resolves #50.