-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate JSSC to sampottinger/jssc #75
Conversation
Started migration of JSSC in response to #71, introducing mac os in this commit.
Looks like constructor in Editor called from from JavaEditor is calling an overloaded method back in JavaEditor that expects debugger to have been initialized which is not possible since the parent constructor has not returned. This switches to loading debugger on demand (upon calling getDebugger) which allows for the Editor to use overloaded methods that expect debugger to be initialized.
Hey there! There's a few PRs outstanding (with inter-dependencies) and the build on master has been broken on Mac for some time. So, I have an integration branch over at https://github.com/sampottinger/processing4 master. That branch includes this PR. This allows one to use Processing 4 again on a Mac along with all of the recent bug fixes. For your convenience, I have made builds available at https://www.datadrivenempathy.com/processing. |
Sorry about 75/76. Too many things going on today. Ok, merging this one w/ binaries since we're building them ourselves. |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
In response to #71, migrate to https://github.com/sampottinger/jssc. This uses the more recent https://github.com/java-native/jssc as the original JSSC is abandoned (?) and there are unresolved issues including failed execution on 64bit Windows as described in #71. Note that processing was not using a clean version of JSSC so @gohai's https://github.com/gohai/java-simple-serial-connector changes are also included. https://github.com/sampottinger/jssc also includes minor bug fixes, especially in the build for mac.
Dependent on / blocked by #74
Resolves #71.