Merged
Conversation
Collaborator
Author
|
Looks like tests aren't passing, will look into it. |
davepagurek
reviewed
Apr 13, 2025
src/core/constants.js
Outdated
| * @typedef {unique symbol} P2D | ||
| * The default, two-dimensional renderer in p5.js. | ||
| * | ||
| * Use this when calling {@link p5.createCanvas|createCanvas} (for example, |
Contributor
There was a problem hiding this comment.
I'm not sure that we support @link yet, this is the result of npm run docs:
It looks like we don't use this syntax elsewhere in the codebase currently, could we keep using the old <a href="#/p5/createCanvas"> for consistency?
davepagurek
reviewed
Apr 13, 2025
| */ | ||
| export const P2D = 'p2d'; | ||
|
|
||
| export const P2DHDR = 'p2d-hdr'; |
Contributor
There was a problem hiding this comment.
I think you'll need to add this line back after your comment block to fix the tests -- looks like the error is that this constant is no longer defined.
Collaborator
Author
|
Sure @davepagurek , sorry for the oversight. |
Contributor
|
No worries! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.