Skip to content

fix: setFrame() under WebGL environment renders the correct frame #7611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
swastikCommits wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: setFrame() under WebGL environment renders the correct frame #7611

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/image/p5.Image.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1807,6 +1807,7 @@ p5.Image = class {
props.lastChangeTime = 0;
props.displayIndex = index;
this.drawingContext.putImageData(props.frames[index].image, 0, 0);
this.setModified(true);
} else {
console.log(
'Cannot set GIF to a frame number that is higher than total number of frames or below zero.'
Expand Down
4 changes: 4 additions & 0 deletions src/webgl/p5.RendererGL.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2090,6 +2090,10 @@ p5.RendererGL = class RendererGL extends p5.Renderer {

const texture = this.textures.get(src);
if (texture) {
if (src.isModified()) { // Assuming isModified() returns the _modified flag
texture.update(src); // Update texture with new image data
src.setModified(false); // Reset the modified flag
}
return texture;
}

Expand Down