[FEAT] Simplify the parameters in the custom GH action #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
♻️ PR Preview efa281d has been successfully destroyed since this PR has been closed.
🤖 By surge-preview |
tbouffard
reviewed
Apr 25, 2022
| description: 'Token to dispatch on the repository' | ||
| required: true | ||
| BUILD_DEMO_WORKFLOW_ID: | ||
| description: 'The identifier of the workflow which is used to build the demo' |
There was a problem hiding this comment.
IntelliJ/Webstorm schema validator complains about the missing required parameter. I suggest we add it even for not required inputs
There was a problem hiding this comment.
Weird, my IntelliJ doesn't complain.
| CUSTOM_PARAMETERS: ', "build_demo_repo": "${{ github.repository }}", | ||
| "build_demo_workflow_id": "post-release-upload-demo-archive-and-trigger-companion-repositories-update.yml", | ||
| "artifact_name": "demo-${{ github.sha }}"' | ||
| BUILD_DEMO_WORKFLOW_ID: "post-release-upload-demo-archive-and-trigger-companion-repositories-update.yml" |
There was a problem hiding this comment.
artifact_name tight the demo generation workflow and this action. I currently don't know if this is an issue or not
There was a problem hiding this comment.
If the name of the demo change, it will be the same for all repositories using this name, because the name is created by this workflow, but we should modify 2 files and not 1.
tbouffard
added
the
chore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.