Skip to content

[FEAT] Render inclusive gateway #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tbouffard merged 6 commits into from
May 13, 2020
Merged

[FEAT] Render inclusive gateway #246

tbouffard merged 6 commits into from
May 13, 2020

Conversation

@aibcmars
Copy link
Contributor

@aibcmars aibcmars commented May 6, 2020

closes #199

@aibcmars aibcmars added the depends on another PR ⚠️ Pull request depending on another one. The depending must be merged first label May 6, 2020
@aibcmars
Copy link
Contributor Author

aibcmars commented May 6, 2020

Depends on #245

@aibcmars aibcmars self-assigned this May 6, 2020
@aibcmars aibcmars force-pushed the 199_render_inclusive_gateway branch from 351fa66 to 843546c Compare May 13, 2020 08:30
@aibcmars aibcmars added BPMN rendering Something about the way the lib is rendering BPMN elements enhancement New feature or request and removed depends on another PR ⚠️ Pull request depending on another one. The depending must be merged first labels May 13, 2020
@csouchet
Copy link
Contributor

csouchet commented May 13, 2020

Is it normal that the circle in the gateway icon is missing ?

Result
image

Expected
image

@tbouffard
Copy link
Member

tbouffard commented May 13, 2020

Is it normal that the circle in the gateway icon is missing ?

Result
image

Expected
image

no it is not, there is a render issue, @aibcmars is on it.
If you check the svg produced by the current implementation, you will see Infinity overload

<path d="M Infinity Infinity Z" fill="#fff" stroke="black" stroke-width="5" stroke-miterlimit="10" pointer-events="all"></path>

@aibcmars
Copy link
Contributor Author

aibcmars commented May 13, 2020

there was issue with merge but actually it showed other thing - size relativity
it all works now
image

@aibcmars aibcmars force-pushed the 199_render_inclusive_gateway branch from 965fa2f to 602aa24 Compare May 13, 2020 12:02
@csouchet csouchet added the rebase needed 💥 Pull request that must be rebased on the latest master commit prior being reviewed or merged label May 13, 2020
@aibcmars aibcmars force-pushed the 199_render_inclusive_gateway branch from 602aa24 to 24e829e Compare May 13, 2020 12:14
@aibcmars aibcmars removed the rebase needed 💥 Pull request that must be rebased on the latest master commit prior being reviewed or merged label May 13, 2020
@aibcmars aibcmars requested review from csouchet and tbouffard and removed request for csouchet May 13, 2020 12:15
@tbouffard
avoid hard coded fill color for the inner circle of the inclusive icon
508c3f4 
use the configured fill color instead. this will help in the future for
extensions
tbouffard
tbouffard approved these changes May 13, 2020
View reviewed changes
Copy link
Member

@tbouffard tbouffard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@aibcmars I just removed an hard coded color with 508c3f4

@tbouffard tbouffard merged commit d659155 into master May 13, 2020
@tbouffard tbouffard deleted the 199_render_inclusive_gateway branch May 13, 2020 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tbouffard tbouffard tbouffard approved these changes

+1 more reviewer

@csouchet csouchet csouchet approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@aibcmars aibcmars

Labels

BPMN rendering Something about the way the lib is rendering BPMN elements enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[FEAT] Render Inclusive Gateway

4 participants

@aibcmars @csouchet @tbouffard