Skip to content

[FEAT] Render Message End Event #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tbouffard merged 4 commits into from
May 13, 2020
Merged

[FEAT] Render Message End Event #241

tbouffard merged 4 commits into from
May 13, 2020

Conversation

@csouchet
Copy link
Contributor

@csouchet csouchet commented May 6, 2020 •
edited
Loading

Closes #240

Depends on #238

image

image

@csouchet csouchet added enhancement New feature or request depends on another PR ⚠️ Pull request depending on another one. The depending must be merged first BPMN rendering Something about the way the lib is rendering BPMN elements labels May 6, 2020
@csouchet csouchet mentioned this pull request May 6, 2020
Merged
@csouchet csouchet marked this pull request as ready for review May 6, 2020 09:36
@csouchet csouchet requested review from aibcmars and tbouffard May 6, 2020 09:47
@csouchet csouchet force-pushed the 240-Render_Message_End_Event branch from 3291e42 to 2c4eb2d Compare May 6, 2020 16:57
@tbouffard tbouffard added the rebase needed 💥 Pull request that must be rebased on the latest master commit prior being reviewed or merged label May 12, 2020
csouchet and others added 2 commits May 12, 2020 20:15
@csouchet @tbouffard
Add the render of Message End Event
eb16784
@tbouffard
update shape render after rebase on master
826b7fe 
The rebase had dropped the previous implementation, so restore it
@tbouffard tbouffard force-pushed the 240-Render_Message_End_Event branch from 2c4eb2d to 826b7fe Compare May 12, 2020 18:24
@tbouffard tbouffard removed depends on another PR ⚠️ Pull request depending on another one. The depending must be merged first rebase needed 💥 Pull request that must be rebased on the latest master commit prior being reviewed or merged labels May 12, 2020
csouchet
csouchet commented May 13, 2020
View reviewed changes
tbouffard and others added 2 commits May 13, 2020 12:00
@tbouffard @csouchet
change of the field used to know if the icon must be filled
4424813 
that match the BPMN spec wording

Co-authored-by: Souchet Céline <[email protected]>
@csouchet
Rename field
ab65efb
@tbouffard tbouffard merged commit b8c193a into master May 13, 2020
@tbouffard tbouffard deleted the 240-Render_Message_End_Event branch May 13, 2020 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tbouffard tbouffard tbouffard approved these changes

+1 more reviewer

@aibcmars aibcmars aibcmars approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

BPMN rendering Something about the way the lib is rendering BPMN elements enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[FEAT] Render Message End Event

4 participants

@csouchet @tbouffard @aibcmars